Make SMTP capability queries case-insensitive - #105
Open
OskarEichler wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SMTP extension keywords are case-insensitive, but public capability queries only find the exact Hash key spelling. This retains the exact-hit fast path and adds an allocation-free case-insensitive fallback over mixed keys.
The isolated and cumulative sources pass 95 tests / 170 assertions on Ruby 4.0.6 and 3.2.11. External query models reproduce two baseline failures and pass after this change; one million hot uppercase queries remain at ten allocations and Mail 2.9.1 local delivery passes. No repository test files were changed.