Exclude arm-linux-musl from native gem builds - #180
Merged
Merged
Conversation
fetch-ci-data started returning arm-linux-musl, which has never shipped. magnus 0.8 fails to compile for it (32-bit musl's `timespec` has padding bitfields), and that one failure skipped the 2.2.0 release entirely. Also skip the Slack release notification on dry runs, which publish nothing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The CD run for #179 (run 36254752545) didn't publish 2.2.0. Every platform built except
arm-linux-musl, which failed compiling magnus:releasedepends on every build job, so it was skipped. Nothing reached RubyGems and no GitHub release was created.arm-linux-muslhas never shipped. 2.1.4's platforms were aarch64-linux, aarch64-linux-musl, aarch64-mingw-ucrt, arm64-darwin, x64-mingw-ucrt, x86_64-darwin, x86_64-linux, and x86_64-linux-musl. The build matrix comes fromoxidize-rb/actions/fetch-ci-data, which has since started including this platform. magnus 0.8 builds atimespecliteral that doesn't account for the padding bitfields on 32-bit musl.Changes
arm-linux-muslto thesupported-ruby-platformsexclude list, next toarm-linux. This restores the exact platform set 2.1.4 shipped.notify_on_releasewhendry_runis set. It gated only onreleasesucceeding, and a dry run succeeds without publishing, so it would have posted "🎉 Released … v2.2.0" to Slack for a release that didn't happen.After merge
CI on main then triggers CD, which sees that 2.2.0 isn't on RubyGems and publishes it. No version bump is needed.