List full platform names in release notes - #182
Merged
Merged
Conversation
The Supported Platforms list kept only the text after the last hyphen of each gem filename, so v2.2.0's notes read "musl, linux, ucrt, darwin, darwin, musl, linux". Its `x86|arm|aarch` filter also dropped x64-mingw-ucrt. Strip the known `code_ownership-<version>-` prefix instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The "Supported Platforms" list that CD writes into each GitHub release is garbled. v2.2.0's read:
The
sedkept only the text after the last hyphen in each gem filename, soaarch64-linux-muslbecamemusl. Thegrep -E '\-(x86|arm|aarch)'filter also droppedx64-mingw-ucrt. v2.2.0's notes have been corrected by hand; this fixes the workflow for future releases.Change
Build the list by stripping the known
code_ownership-<version>-prefix and.gemsuffix from each platform gem. The source gem doesn't match the glob, so it's excluded without a filter.Verification
The "Create GitHub Release" step can't run in a dry run, so I extracted its
runscript fromcd.ymland ran it locally against v2.2.0's nine asset filenames, withghstubbed out:main, it reproduces the garbled list above exactly.2.3.0.pre.1) and a source-gem-onlypkg/both come out right. The latter gives an empty list rather than- *.actionlint's findings are unchanged except for one removed: the
ls | grepwarning (SC2010).