Bump version to 0.5.0 - #134
Merged
Merged
Conversation
A minor bump, because both changes since 0.4.0 are visible to consumers:
- The generated CODEOWNERS now writes the "Annotations at the top of file"
section last (#130), so GitHub's last-match-wins routing agrees with
`for-file`. Every consumer's CODEOWNERS changes on upgrade, so `validate`
reports it out of date until it's regenerated.
- `find_file_owners` caches loaded teams for the life of the process (#129),
so team files added or edited mid-process aren't seen until
`clear_team_cache()` runs or the process restarts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps
codeowners-rsto 0.5.0, releasing the two changes merged sincev0.4.0.Why 0.5.0, not 0.4.1
Both changes are visible to consumers:
for-file. It also means every consumer's generated CODEOWNERS changes on upgrade:validatereports the file out of date until it's regenerated. Plainbin/codeownership validateautocorrects and stages it, but CI that runsvalidate --skip-autocorrectwill fail until someone regenerates and commits.clear_team_cache()runs or the process restarts. That matters for long-lived processes such as a Rails dev server or console.Releasing
Merging publishes. The release job fires when the newest commit on
mainchanges the version, and squash-only merging makes this PR that commit; I checked the detection against it with BSDgrep:new_version=v0.5.0. #133 (test-only) can merge before or after this without affecting the release.After merge
code_ownershipstill pinsv0.3.3, so Ruby users get none of 0.4.0 or 0.5.0 until it bumps. That bump must also bindclear_team_cacheand call it fromCodeOwnership.bust_caches!; otherwisebust_caches!no longer fully resets ownership once perf: cache loaded teams in find_file_owners #129 ships.Sent with Claude Code