Skip to content

Report tag_name as ShadowRoot for shadow roots #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
route merged 1 commit into from
Jul 9, 2026
+2 −3
Merged

Report tag_name as ShadowRoot for shadow roots #318

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/capybara/cuprite/node.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ def unselect_option
end

def tag_name
@tag_name ||= description["nodeName"].downcase
@tag_name ||= description["shadowRootType"] ? "ShadowRoot" : description["nodeName"].downcase
end

def visible?
Expand Down
2 changes: 1 addition & 1 deletion spec/features/session_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,7 +452,7 @@
shadow_root = @session.find(:css, "#shadow_host").shadow_root
expect do
expect(shadow_root).to have_css("#shadow_content", text: "Not in the document")
end.to raise_error(/tag="#document-fragment"/)
end.to raise_error(/tag="ShadowRoot"/)
end

it "extends visibility check across shadow host boundary" do
Expand Down
1 change: 0 additions & 1 deletion spec/spec_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@ module TestSessions
node #visible? details non-summary descendants should be non-visible
node #visible? works when details is toggled open and closed
node #set should submit single text input forms if ended with
node #shadow_root should produce error messages when failing
#has_field with valid should be false if field is invalid
#has_element? should be true if the given element is on the page
#assert_matches_style should raise error if the elements style doesn't contain the given properties
Expand Down
Loading