CheckoutBuilder: bind baseline{,_index}#1284
Open
jonathantanmy2 wants to merge 1 commit into
Open
Conversation
Add support for the `baseline` and `baseline_index` fields in CheckoutBuilder (to `struct git_checkout_options`). Regarding lifetime of arguments passed to CheckoutBuilder, unlike the other fields in which owned versions are created upon function invocation, CheckoutBuilder only takes references to the input tree (`baseline()`) and index (`baseline_index()`) respectively. The Rust borrow checker enforces that the references live at least as long as CheckoutBuilder does. Regarding safety of conversion of these new fields from CheckoutBuilder to `struct git_checkout_options` (in `configure()`), it is as unsafe as it currently is: the resulting `struct git_checkout_options` is valid as long as the source CheckoutBuilder lives.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for the
baselineandbaseline_indexfields in CheckoutBuilder (tostruct git_checkout_options).Regarding lifetime of arguments passed to CheckoutBuilder, unlike the other fields in which owned versions are created upon function invocation, CheckoutBuilder only takes references to the input tree (
baseline()) and index (baseline_index()) respectively. The Rust borrow checker enforces that the references live at least as long as CheckoutBuilder does.Regarding safety of conversion of these new fields from CheckoutBuilder to
struct git_checkout_options(inconfigure()), it is as unsafe as it currently is: the resultingstruct git_checkout_optionsis valid as long as the source CheckoutBuilder lives.