Fix unspecified transmute between slice types - #5440
Open
weiznich wants to merge 1 commit into
Open
Conversation
This comment has been minimized.
This comment has been minimized.
weiznich
force-pushed
the
fix_unspecified_transmute
branch
from
August 26, 2026 12:25
ec04665 to
c8fcd3c
Compare
Member
|
The change LGTM but could you file this against the |
The layout of slices is currently not specified in Rust. This PR replaces a `transmute` between slices of different types with the equivalent pointer cast to keep all involved behaviour specified.
weiznich
force-pushed
the
fix_unspecified_transmute
branch
from
August 27, 2026 06:49
c8fcd3c to
b02a6a4
Compare
Author
|
I rebased the PR and changed the base branch. Sorry for the noise from the bot :( |
tgross35
approved these changes
Aug 27, 2026
tgross35
enabled auto-merge
August 27, 2026 06:52
tgross35
added
the
stable-nominated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The layout of slices is currently not specified in Rust. This PR replaces a
transmutebetween slices of different types with the equivalent pointer cast to keep all involved behaviour specified.