Give VaList its own home - #126921
Merged
Merged
Give VaList its own home#126921
Conversation
rustbot
added
A-run-make
commented
Jun 24, 2024
Collaborator
|
This PR modifies cc @jieyouxu |
This comment has been minimized.
This comment has been minimized.
workingjubilee
force-pushed
the
outline-va-list
branch
from
June 24, 2024 22:17
af74cf3 to
652e708
Compare
This comment has been minimized.
This comment has been minimized.
workingjubilee
force-pushed
the
outline-va-list
branch
from
June 24, 2024 22:27
652e708 to
55db901
Compare
This comment has been minimized.
This comment has been minimized.
workingjubilee
force-pushed
the
outline-va-list
branch
from
June 24, 2024 23:15
55db901 to
308e819
Compare
Urgau
reviewed
Jun 25, 2024
| ))] | ||
| #[cfg_attr(not(doc), repr(transparent))] // work around https://github.com/rust-lang/rust/issues/90435 | ||
| #[lang = "va_list"] | ||
| pub struct VaListImpl<'f> { |
Member
There was a problem hiding this comment.
Shouldn't those platform-dependant VaListImpl struct be moved into the corresponding PAL?
commented
Jun 26, 2024
Collaborator
|
☔ The latest upstream changes (presumably #126965) made this pull request unmergeable. Please resolve the merge conflicts. |
added 2 commits
July 4, 2024 20:34
and reexport
Now that VaList, et al. have a module, they only need one `#[unstable]`.
workingjubilee
force-pushed
the
outline-va-list
branch
from
July 5, 2024 03:35
308e819 to
c1a29b3
Compare
commented
Jul 5, 2024
Member
Author
|
This is now just internal-only. r? libs |
commented
Jul 7, 2024
Member
|
may it live peacefully in its new home. |
commented
Jul 7, 2024
Collaborator
bors
added
S-waiting-on-bors
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just rearranging things internally and reexporting.