Rename macro `SmartPointer` to `CoercePointee` by dingxiangfei2009 · Pull Request #131284 · rust-lang/rust

dingxiangfei2009 · 2024-10-05T09:49:28Z

As per resolution #129104 we will rename the macro to better reflect the technical specification of the feature and clarify the communication.

SmartPointer is renamed to CoercePointee
#![feature(derive_smart_pointer)] gate is renamed to #![feature(derive_coerce_pointee)].
Any mention of SmartPointer in the file names are renamed accordingly.

r? @compiler-errors

cc @nikomatsakis @Darksonn

dingxiangfei2009 · 2024-10-05T09:50:00Z

@rustbot labels +F-derive_smart_pointer

dingxiangfei2009 · 2024-10-05T09:51:33Z

-#[unstable(feature = "derive_smart_pointer", issue = "123430")]
-pub macro SmartPointer($item:item) {
+#[unstable(feature = "dervie_coerce_referent", issue = "123430")]
+#[cfg(not(bootstrap))]


I will remove this in the next beta release.

You don't need to remove it; it'll get removed by the release team member doing the beta release.

ghost · 2024-10-05T14:30:19Z

@rustbot blocked

Blocked on FCP finishing

ghost · 2024-10-05T14:30:52Z

    (incomplete, deref_patterns, "1.79.0", Some(87121)),
-    /// Allows deriving `SmartPointer` traits
-    (unstable, derive_smart_pointer, "1.79.0", Some(123430)),
+    /// Allows deriving `CoerceReferent` traits


I believe you should register derive_smart_pointer as a removed feature, or perhaps look into how we've handled renamed features in the past.

Applied. I moved it into the removed list.

ghost · 2024-10-07T22:00:02Z

☔ The latest upstream changes (presumably #131372) made this pull request unmergeable. Please resolve the merge conflicts.

ghost · 2024-10-09T19:34:15Z

@rustbot ready

The latest decision as per comment is CoercePointee.

ghost · 2024-10-09T19:37:14Z

This is still waiting for the FCP to finish. To avoid additional churn, and since I see no rush here:

@rustbot blocked

ghost · 2024-10-12T21:54:02Z

☔ The latest upstream changes (presumably #131612) made this pull request unmergeable. Please resolve the merge conflicts.

move derive_smart_pointer into removed set

ghost · 2024-10-23T18:20:08Z

+    /// Allows deriving traits as per `CoercePointee` specification
+    (unstable, derive_coerce_pointee, "1.79.0", Some(123430)),


Why is this a lang feature at all? The feature gating should be a library feature, since all this gates is a macro, and no behavior in the compiler.

I believe that you can remove this.

ghost · 2024-10-23T18:27:35Z

+    /// Allows deriving traits as per `CoercePointee` specification
+    (unstable, derive_coerce_pointee, "1.79.0", Some(123430)),


Suggested change

/// Allows deriving traits as per `CoercePointee` specification

(unstable, derive_coerce_pointee, "1.79.0", Some(123430)),

per @compiler-errors's comment

ghost · 2024-10-27T15:41:39Z

@bors r+

ghost · 2024-10-27T15:41:41Z

📌 Commit 6cb84fe has been approved by compiler-errors

It is now in the queue for this repository.

ghost · 2024-10-27T17:04:16Z

⌛ Testing commit 6cb84fe with merge 81d6652...

ghost · 2024-10-27T19:59:11Z

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing 81d6652 to master...

ghost · 2024-10-27T21:18:12Z

Finished benchmarking commit (81d6652): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.4%	[-2.4%, -2.4%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (secondary -3.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.2%	[-5.0%, -1.5%]	2
All ❌✅ (primary)	-	-	0

Cycles

Results (secondary 9.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	9.3%	[9.1%, 9.6%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 783.479s -> 782.673s (-0.10%)
Artifact size: 333.71 MiB -> 333.75 MiB (0.01%)

ghost · 2024-11-15T19:48:50Z

The issue description (first comment) does not match the implementation. Can we update it?

ghost · 2024-11-29T11:29:51Z

@oxalica

Thank you for pointing it out! I have updated the description.

There had been flips and flops on terminology back then. This will finally set the record straight.

rustbot assigned compiler-errors Oct 5, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 5, 2024

rustbot added the F-derive_coerce_pointee Feature: RFC 3621's oft-renamed implementation label Oct 5, 2024

dingxiangfei2009 commented Oct 5, 2024

View reviewed changes

This comment has been minimized.

Sign in to view

dingxiangfei2009 force-pushed the rename-smart-ptr-to-coerce-referent branch from 2d31f15 to ffef110 Compare October 5, 2024 10:02

This comment has been minimized.

Sign in to view

dingxiangfei2009 force-pushed the rename-smart-ptr-to-coerce-referent branch 2 times, most recently from a761a7b to b5f8711 Compare October 5, 2024 10:19

rustbot added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 5, 2024

compiler-errors reviewed Oct 5, 2024

View reviewed changes

fmease added the S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. label Oct 5, 2024

dingxiangfei2009 force-pushed the rename-smart-ptr-to-coerce-referent branch 2 times, most recently from 6e7d624 to d83b461 Compare October 9, 2024 19:32

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Oct 9, 2024

dingxiangfei2009 changed the title ~~Rename macro SmartPointer to CoerceReferent~~ Rename macro SmartPointer to CoercePointee Oct 9, 2024

dingxiangfei2009 force-pushed the rename-smart-ptr-to-coerce-referent branch from d83b461 to ad79281 Compare October 9, 2024 19:36

rustbot added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 9, 2024

s/SmartPointer/CoerceReferent/g

fd36b3a

move derive_smart_pointer into removed set

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 23, 2024

compiler-errors reviewed Oct 23, 2024

View reviewed changes

nikomatsakis reviewed Oct 23, 2024

View reviewed changes

apply suggestion

6cb84fe

nikomatsakis mentioned this pull request Oct 26, 2024

Getting Rust for Linux into stable Rust: language features rust-lang/goals#116

Closed

53 tasks

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 27, 2024

matthiaskrgr mentioned this pull request Oct 27, 2024

Rollup of 3 pull requests #132229

Closed

bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 27, 2024

bors merged commit 81d6652 into rust-lang:master Oct 27, 2024

rustbot added this to the 1.84.0 milestone Oct 27, 2024

This was referenced Oct 27, 2024

Remove P<> from visit_s in ast MutVisitor #132112

Closed

Support multiple stability attributes on items #131824

Closed

dingxiangfei2009 deleted the rename-smart-ptr-to-coerce-referent branch October 31, 2024 21:19

Darksonn mentioned this pull request Nov 15, 2024

Decide on name for derive(SmartPtr) #129104

Closed

ojeda mentioned this pull request Nov 16, 2024

Rust unstable features needed for the kernel Rust-for-Linux/linux#2

Open

55 tasks

		/// Allows deriving traits as per `CoercePointee` specification
		(unstable, derive_coerce_pointee, "1.79.0", Some(123430)),

Uh oh!

Uh oh!

Conversation

dingxiangfei2009 commented Oct 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dingxiangfei2009 commented Oct 5, 2024

Uh oh!

dingxiangfei2009 Oct 5, 2024

Choose a reason for hiding this comment

Uh oh!

ghost Oct 23, 2024

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

ghost commented Oct 5, 2024

Uh oh!

ghost Oct 5, 2024 • edited by compiler-errors Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ghost Oct 9, 2024

Choose a reason for hiding this comment

Uh oh!

ghost commented Oct 7, 2024

Uh oh!

ghost commented Oct 9, 2024

Uh oh!

ghost commented Oct 9, 2024

Uh oh!

ghost commented Oct 12, 2024

Uh oh!

ghost Oct 23, 2024

Choose a reason for hiding this comment

Uh oh!

ghost Oct 23, 2024

Choose a reason for hiding this comment

Uh oh!

ghost commented Oct 27, 2024

Uh oh!

ghost commented Oct 27, 2024

Uh oh!

ghost commented Oct 27, 2024

Uh oh!

ghost commented Oct 27, 2024

Uh oh!

ghost commented Oct 27, 2024

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

ghost commented Nov 15, 2024

Uh oh!

ghost commented Nov 29, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

dingxiangfei2009 commented Oct 5, 2024 •

edited

Loading

ghost Oct 5, 2024 •

edited by compiler-errors

Loading