Adds support for AArch64 SVE to inline assembly by CrooseGit · Pull Request #158312 · rust-lang/rust

CrooseGit · 2026-06-23T16:32:20Z

No description provided.

rustbot · 2026-06-23T16:32:23Z

rustc_codegen_cranelift is developed in its own repository. If possible, consider making this change to rust-lang/rustc_codegen_cranelift instead.

cc @bjorn3

rustc_codegen_gcc is developed in its own repository. If possible, consider making this change to rust-lang/rustc_codegen_gcc instead.

cc @antoyo, @GuillaumeGomez

rustbot · 2026-06-23T16:32:26Z

r? @nikomatsakis

rustbot has assigned @nikomatsakis.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 73 candidates
Random selection from 21 candidates

davidtwco · 2026-07-06T14:37:02Z

r? compiler

tiif · 2026-07-09T13:39:49Z

r? compiler

hanna-kruppe · 2026-07-11T12:27:43Z

r? compiler

davidtwco · 2026-07-13T09:19:11Z

r? @Amanieu

Amanieu · 2026-08-23T13:50:18Z

Finally getting around to reviewing this, sorry for the delay.

Why did you choose to make zreg a separate register class from vreg? I feel that the design would be much cleaner if all we did was enable more types to be used with vreg when the sve feature is available.

Other than that detail, the rest of the code mostly looks correct.

Amanieu · 2026-08-25T02:29:14Z

I made 2 changes:

zreg is removed, instead Z registers are represented using a z modifier on vreg.
ffr is moved out of preg into a separate ffr clobber-only class.

Also blesses existing tests to make way for sve asm support

Facilitates scalable vector support in inline assembly.

Adds new `zreg` register type and `SveVec*` variants to `InlineAsmType`

rustbot · 2026-09-04T13:30:08Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

davidtwco · 2026-09-04T13:30:30Z

Rebased this, not sure how you want to handle the review @Amanieu as we've both made some changes

Amanieu · 2026-09-05T01:11:07Z

Given that we've reviewed each other's changes, let's just...

@bors r+

rust-bors · 2026-09-05T01:11:10Z

📌 Commit c91f5cb has been approved by Amanieu

It is now in the queue for this repository.

…port, r=Amanieu Adds support for AArch64 SVE to inline assembly

Rollup of 14 pull requests Successful merges: - #162324 (miri subtree update) - #162170 (bootstrap: use target's LLVM libdir when cross-compiling) - #158312 (Adds support for AArch64 SVE to inline assembly) - #159792 (A more readable debug map for IndexMaps) - #160745 (make closures act like MaybeDangling) - #161263 (break rustc_expand-rustc_middle dependency) - #161895 (std::sys::pal::sgx: fix mismatched alloc/free alignment) - #161940 (Promote `wasm32-wasip3` to a tier 2 target) - #161397 (coverage: Tidy tests and add some new ones) - #161616 (Report precondition violation for `<usize as SliceIndex>::get_unchecked` in const-eval) - #162248 (Add regression test for unsized const parameter default ICE) - #162250 (Fix hashing of span end columns in incremental compilation) - #162265 (cargotest: add lockfiles) - #162318 (bootstrap: Fix broken path for `./x doc compiler/rustc --open`)

Rollup merge of #158312 - CrooseGit:dev/reucru01/sve-asm-support, r=Amanieu Adds support for AArch64 SVE to inline assembly

rust-timer · 2026-09-06T03:36:39Z

Note

This PR was benchmarked as part of triage of its containing rollup: triage URL.

Finished benchmarking commit (778219a): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (primary -1.9%, secondary -0.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	5.9%	[5.9%, 5.9%]	1
Improvements ✅ (primary)	-1.9%	[-2.7%, -1.2%]	4
Improvements ✅ (secondary)	-2.4%	[-2.6%, -2.0%]	3
All ❌✅ (primary)	-1.9%	[-2.7%, -1.2%]	4

Cycles

This perf run didn't have relevant results for this metric.

Binary size

Results (primary 0.0%, secondary 0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.0%	[0.0%, 0.1%]	11
Regressions ❌ (secondary)	0.1%	[0.1%, 0.1%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.0%	[0.0%, 0.1%]	11

Bootstrap: missing data
Artifact size: 403.33 MiB -> 403.31 MiB (-0.01%)

Rollup of 14 pull requests Successful merges: - rust-lang/rust#162324 (miri subtree update) - rust-lang/rust#162170 (bootstrap: use target's LLVM libdir when cross-compiling) - rust-lang/rust#158312 (Adds support for AArch64 SVE to inline assembly) - rust-lang/rust#159792 (A more readable debug map for IndexMaps) - rust-lang/rust#160745 (make closures act like MaybeDangling) - rust-lang/rust#161263 (break rustc_expand-rustc_middle dependency) - rust-lang/rust#161895 (std::sys::pal::sgx: fix mismatched alloc/free alignment) - rust-lang/rust#161940 (Promote `wasm32-wasip3` to a tier 2 target) - rust-lang/rust#161397 (coverage: Tidy tests and add some new ones) - rust-lang/rust#161616 (Report precondition violation for `<usize as SliceIndex>::get_unchecked` in const-eval) - rust-lang/rust#162248 (Add regression test for unsized const parameter default ICE) - rust-lang/rust#162250 (Fix hashing of span end columns in incremental compilation) - rust-lang/rust#162265 (cargotest: add lockfiles) - rust-lang/rust#162318 (bootstrap: Fix broken path for `./x doc compiler/rustc --open`)

rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 23, 2026

rustbot assigned nikomatsakis Jun 23, 2026

rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jun 23, 2026

This comment has been minimized.

Sign in to view

CrooseGit force-pushed the dev/reucru01/sve-asm-support branch from 544d13e to 29690b5 Compare June 24, 2026 10:11

This comment has been minimized.

Sign in to view

rustbot assigned tiif and unassigned nikomatsakis Jul 6, 2026

rustbot assigned hanna-kruppe and unassigned tiif Jul 9, 2026

rustbot assigned TaKO8Ki and unassigned hanna-kruppe Jul 11, 2026

rustbot assigned Amanieu and unassigned TaKO8Ki Jul 13, 2026

This was referenced Jul 15, 2026

Tracking Issue for Scalable Vectors (stdarch_aarch64_sve) #145052

Open

Sized Hierarchy and Scalable Vectors rust-lang/goals#270

Open

This comment was marked as resolved.

Sign in to view

davidtwco force-pushed the dev/reucru01/sve-asm-support branch from 29690b5 to 140fb02 Compare August 19, 2026 10:47

This comment has been minimized.

Sign in to view

davidtwco force-pushed the dev/reucru01/sve-asm-support branch from 140fb02 to 5a331e4 Compare August 19, 2026 11:04

Amanieu mentioned this pull request Aug 25, 2026

Add SVE-accelerated Vec::retain_mut for aarch64 #161034

Merged

This comment has been minimized.

Sign in to view

CrooseGit and others added 5 commits September 4, 2026 13:29

Adds tests for SVE inline asm

49de62e

Also blesses existing tests to make way for sve asm support

Creates new InlineAsmSize enum

cbe88ad

Facilitates scalable vector support in inline assembly.

Adds support for AArch64 SVE to inline assembly

7b2bfec

Adds new `zreg` register type and `SveVec*` variants to `InlineAsmType`

Merge zreg into vreg and keep ffr in a clobber-only class

51b3f52

Gate asm support for SVE under asm_experimental_reg

c91f5cb

davidtwco force-pushed the dev/reucru01/sve-asm-support branch from 36a84c5 to c91f5cb Compare September 4, 2026 13:30

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 5, 2026

Zalathar added a commit to Zalathar/rust that referenced this pull request Sep 5, 2026

Rollup merge of rust-lang#158312 - CrooseGit:dev/reucru01/sve-asm-sup…

32f6fc8

…port, r=Amanieu Adds support for AArch64 SVE to inline assembly

Zalathar mentioned this pull request Sep 5, 2026

Rollup of 20 pull requests #162317

Closed

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Sep 5, 2026

Rollup merge of rust-lang#158312 - CrooseGit:dev/reucru01/sve-asm-sup…

cccabef

…port, r=Amanieu Adds support for AArch64 SVE to inline assembly

JonathanBrouwer mentioned this pull request Sep 5, 2026

Rollup of 14 pull requests #162327

Closed

Zalathar mentioned this pull request Sep 5, 2026

Rollup of 14 pull requests #162333

Merged

rust-bors Bot merged commit f6f7d61 into rust-lang:main Sep 5, 2026
13 checks passed

rustbot added this to the 1.100.0 milestone Sep 5, 2026

rust-bors Bot pushed a commit that referenced this pull request Sep 5, 2026

Unrolled build for #158312 in rollup 162333

778219a

Rollup merge of #158312 - CrooseGit:dev/reucru01/sve-asm-support, r=Amanieu Adds support for AArch64 SVE to inline assembly

Uh oh!

Uh oh!

Conversation

CrooseGit commented Jun 23, 2026

Uh oh!

rustbot commented Jun 23, 2026

Uh oh!

rustbot commented Jun 23, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

davidtwco commented Jul 6, 2026

Uh oh!

tiif commented Jul 9, 2026

Uh oh!

hanna-kruppe commented Jul 11, 2026

Uh oh!

davidtwco commented Jul 13, 2026

Uh oh!

This comment was marked as resolved.

This comment has been minimized.

This comment has been minimized.

Amanieu commented Aug 23, 2026

Uh oh!

Amanieu commented Aug 25, 2026

Uh oh!

This comment has been minimized.

rustbot commented Sep 4, 2026

Uh oh!

davidtwco commented Sep 4, 2026

Uh oh!

Amanieu commented Sep 5, 2026

Uh oh!

rust-bors Bot commented Sep 5, 2026

Uh oh!

Uh oh!

rust-timer commented Sep 6, 2026

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants