Prefer ModId in more places by camsteffen · Pull Request #159787 · rust-lang/rust

camsteffen · 2026-07-23T19:08:43Z

Simplifying code a bit and adding consistency. Generally prefer passing around ModId instead of a more specific ID when a ModId will do.

rustbot · 2026-07-23T19:08:49Z

HIR ty lowering was modified

cc @fmease

rustbot · 2026-07-23T19:08:52Z

r? @mu001999

rustbot has assigned @mu001999.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 74 candidates
Random selection from 20 candidates

mu001999 · 2026-07-24T05:08:44Z

@bors try @rust-timer queue

Cache and use more ModId

rust-bors · 2026-07-24T07:13:58Z

☀️ Try build successful (CI)
Build commit: d23ae58 (d23ae583eaadc5bb12614b8b6dc9e36776122523)
Base parent: 76c35a1 (76c35a14a45897a366c11657ecbbe9ec4153ad17)

rust-timer · 2026-07-24T08:03:23Z

Finished benchmarking commit (d23ae58): comparison URL.

Overall result: ❌ regressions - please read:

Benchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf.

Next, please: If you can, justify the regressions found in this try perf run in writing along with @rustbot label: +perf-regression-triaged. If not, fix the regressions and do another perf run. Neutral or positive results will clear the label automatically.

@bors rollup=never rustc-perf
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.2%	[0.2%, 0.3%]	12
Regressions ❌ (secondary)	0.3%	[0.1%, 0.5%]	18
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.2%	[0.2%, 0.3%]	12

Max RSS (memory usage)

Results (secondary -0.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.7%	[2.7%, 2.7%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.4%	[-2.6%, -2.2%]	2
All ❌✅ (primary)	-	-	0

Cycles

This perf run didn't have relevant results for this metric.

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 488.274s -> 486.771s (-0.31%)
Artifact size: 387.66 MiB -> 387.61 MiB (-0.01%)

mu001999 · 2026-07-24T08:29:47Z

Seems this instead leads to a slight perf regression. Do you have any ideas?

@rustbot author

rustbot · 2026-07-24T23:50:28Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

Use ModId more for visibility checks from TypeckRootCtxt. This just simplifies things a bit and adds consistency.

We generally expect Visibility to have ModId or LocalModId, so it seems good to restrict the impls as such. There is just one error path needing adjustment to check that we actually have a ModId. It should be okay since, if it is not a module, an error will be emitted elsewhere.

Especially in adjust_ident_and_get_scope and is_accessible_from.

rustbot · 2026-08-28T01:48:14Z

clippy is developed in its own repository. If possible, consider making this change to rust-lang/rust-clippy instead.

cc @rust-lang/clippy

rustbot · 2026-08-28T01:48:17Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

camsteffen · 2026-08-28T01:53:39Z

This should be about perf neutral now. Adding a ModId to ItemCtxt was a loss so I took that out.

mu001999 · 2026-08-28T06:01:37Z

@bors try @rust-timer queue

Prefer ModId in more places

rust-bors · 2026-08-28T07:00:23Z

☀️ Try build successful (CI)
Build commit: 5eb45c3 (5eb45c324decbc218a78c4fc379dd769318e60d7)
Base parent: d0f2ef5 (d0f2ef5e53039bd86fdcaa6e71860c4948880e04)

rust-timer · 2026-08-28T07:43:13Z

Finished benchmarking commit (5eb45c3): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up.

@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (primary -2.3%, secondary 2.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	7.1%	[7.1%, 7.1%]	1
Improvements ✅ (primary)	-2.3%	[-2.3%, -2.3%]	1
Improvements ✅ (secondary)	-2.3%	[-2.3%, -2.3%]	1
All ❌✅ (primary)	-2.3%	[-2.3%, -2.3%]	1

Cycles

Results (primary -0.5%, secondary 10.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	3.2%	[3.2%, 3.2%]	1
Regressions ❌ (secondary)	10.6%	[3.0%, 18.3%]	4
Improvements ✅ (primary)	-2.4%	[-2.6%, -2.2%]	2
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.5%	[-2.6%, 3.2%]	3

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 475.629s -> 474.896s (-0.15%)
Artifact size: 402.76 MiB -> 402.77 MiB (0.00%)

mu001999 · 2026-08-28T07:59:02Z

+    let (module, _span) = tcx.hir_get_module(mod_id);

-    cx.with_lint_attrs(hir_id, |cx| {
+    cx.with_lint_attrs(HirId::make_owner(mod_id.to_local_def_id()), |cx| {


Suggested change

cx.with_lint_attrs(HirId::make_owner(mod_id.to_local_def_id()), |cx| {

cx.with_lint_attrs(mod_id.into(), |cx| {

View changes since the review

mu001999 · 2026-08-28T08:57:57Z

r=me after nits

@rustbot author

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 23, 2026

rustbot assigned mu001999 Jul 23, 2026

camsteffen force-pushed the fnctxt-modid branch from 9d9e28b to 59f64b4 Compare July 23, 2026 19:15

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 24, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Jul 24, 2026

Auto merge of #159787 - camsteffen:fnctxt-modid, r=<try>

d23ae58

Cache and use more ModId

This comment has been minimized.

Sign in to view

rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Jul 24, 2026

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 24, 2026

This comment has been minimized.

Sign in to view

camsteffen added 4 commits August 27, 2026 20:42

Add mod_id to TypeckRootCtxt

3976170

Use ModId more for visibility checks from TypeckRootCtxt. This just simplifies things a bit and adds consistency.

Prefer ModId in more places

2ffa24a

Especially in adjust_ident_and_get_scope and is_accessible_from.

Use ModId more in late lint pass

afa08c3

camsteffen force-pushed the fnctxt-modid branch from 59f64b4 to afa08c3 Compare August 28, 2026 01:48

rustbot added T-clippy Relevant to the Clippy team. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Aug 28, 2026

camsteffen changed the title ~~Cache and use more ModId~~ Prefer ModId in more places Aug 28, 2026

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 28, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Aug 28, 2026

Auto merge of #159787 - camsteffen:fnctxt-modid, r=<try>

5eb45c3

Prefer ModId in more places

This comment has been minimized.

Sign in to view

rustbot removed perf-regression Performance regression. S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Aug 28, 2026

mu001999 reviewed Aug 28, 2026

View reviewed changes

	cx.with_lint_attrs(HirId::make_owner(mod_id.to_local_def_id()), \|cx\| {
	cx.with_lint_attrs(mod_id.into(), \|cx\| {

Uh oh!

Uh oh!

Conversation

camsteffen commented Jul 23, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jul 23, 2026

Uh oh!

rustbot commented Jul 23, 2026

Uh oh!

mu001999 commented Jul 24, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-bors Bot commented Jul 24, 2026

Uh oh!

This comment has been minimized.

rust-timer commented Jul 24, 2026

Overall result: ❌ regressions - please read:

Uh oh!

mu001999 commented Jul 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jul 24, 2026

Uh oh!

This comment has been minimized.

rustbot commented Aug 28, 2026

Uh oh!

rustbot commented Aug 28, 2026

Uh oh!

camsteffen commented Aug 28, 2026

Uh oh!

mu001999 commented Aug 28, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-bors Bot commented Aug 28, 2026

Uh oh!

This comment has been minimized.

rust-timer commented Aug 28, 2026

Overall result: no relevant changes - no action needed

Uh oh!

mu001999 Aug 28, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mu001999 commented Aug 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

camsteffen commented Jul 23, 2026 •

edited by rustbot

Loading

mu001999 commented Jul 24, 2026 •

edited

Loading

mu001999 Aug 28, 2026 •

edited by rustbot

Loading