Skip to content

Optimize CharIndices offset consumers - #161071

Closed
SomeFlyingThing wants to merge 1 commit into
rust-lang:mainfrom
SomeFlyingThing:agent/audit-type-hints-4
Closed

Optimize CharIndices offset consumers#161071
SomeFlyingThing wants to merge 1 commit into
rust-lang:mainfrom
SomeFlyingThing:agent/audit-type-hints-4

Conversation

@SomeFlyingThing

Copy link
Copy Markdown
Contributor

Hint that it doesn’t exceed Isize max

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 13, 2026
@rustbot

rustbot commented Aug 13, 2026

Copy link
Copy Markdown
Collaborator

r? @JohnTitor

rustbot has assigned @JohnTitor.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 75 candidates
  • Random selection from 17 candidates

@hanna-kruppe

Copy link
Copy Markdown
Contributor

I'm going to go ahead and close this, as it's adding an assume without good motivation or benchmarks, which we're generally skeptical of for reasons mentioned in #161063 (comment) (and also being discussed more generally on Zulip). If you do have better motivation for this change, please open a new PR (also in line with our LLM Usage Policy).

@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants