Skip to content

Treat generics in trait and projection bounds as live always - #161154

Draft
jackh726 wants to merge 2 commits into
rust-lang:mainfrom
jackh726:opaque-liveness-v2
Draft

Treat generics in trait and projection bounds as live always#161154
jackh726 wants to merge 2 commits into
rust-lang:mainfrom
jackh726:opaque-liveness-v2

Conversation

@jackh726

Copy link
Copy Markdown
Member

(for crater run)

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 16, 2026
@jackh726 jackh726 changed the title Treat generics in trait and projection bounds as live always @jackh726 Treat generics in trait and projection bounds as live always Aug 16, 2026
@jackh726

Copy link
Copy Markdown
Member Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 16, 2026
@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Aug 16, 2026
 Treat generics in trait and projection bounds as live always
@rust-bors

rust-bors Bot commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 49a6044 (49a6044d37d694890450f52ceaceb66277a36b1e)
Base parent: 67854e5 (67854e511de21d881bb16426996cd4259d44aa2e)

@rust-timer

This comment has been minimized.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (49a6044): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up.

@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (secondary -0.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
1.0% [1.0%, 1.0%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.1% [-2.1%, -2.1%] 1
All ❌✅ (primary) - - 0

Cycles

Results (secondary 2.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
5.9% [2.0%, 9.9%] 5
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-3.0% [-4.8%, -2.1%] 4
All ❌✅ (primary) - - 0

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 459.382s -> 459.414s (0.01%)
Artifact size: 396.87 MiB -> 398.81 MiB (0.49%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 16, 2026
@jackh726

Copy link
Copy Markdown
Member Author

@craterbot check

@craterbot

Copy link
Copy Markdown
Collaborator

👌 Experiment pr-161154 created and queued.
🤖 Automatically detected try build 49a6044
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 16, 2026
@jackh726

Copy link
Copy Markdown
Member Author

@craterbot p=1

Polonius Alpha is already enabled on nightly - it would be good to be prompt in figuring out if we can make this change to close some soundness holes.

@craterbot

Copy link
Copy Markdown
Collaborator

📝 Configuration of the pr-161154 experiment changed.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@rust-bors

rust-bors Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

☔ The latest upstream changes (presumably #161272) made this pull request unmergeable. Please resolve the merge conflicts by rebasing.

@theemathas

Copy link
Copy Markdown
Contributor

This seems more urgent than the --release run of the beta crater.

@craterbot p=4

@craterbot

Copy link
Copy Markdown
Collaborator

📝 Configuration of the pr-161154 experiment changed.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot

Copy link
Copy Markdown
Collaborator

🚧 Experiment pr-161154 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot

Copy link
Copy Markdown
Collaborator

🎉 Experiment pr-161154 is completed!
📊 98 regressed and 2 fixed (1080274 total)
📊 6304 spurious results on the retry-regressed-list.txt, consider a retry1 if this is a significant amount.
📰 Open the summary report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

Footnotes

  1. re-run the experiment with crates=https://crater-reports.s3.amazonaws.com/pr-161154/retry-regressed-list.txt

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Aug 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants