Skip to content

Rename extern "unadjusted" to extern "llvm-intrinsic" - #161398

Open
bjorn3 wants to merge 6 commits into
rust-lang:mainfrom
bjorn3:rename_unadjusted_abi
Open

Rename extern "unadjusted" to extern "llvm-intrinsic"#161398
bjorn3 wants to merge 6 commits into
rust-lang:mainfrom
bjorn3:rename_unadjusted_abi

Conversation

@bjorn3

@bjorn3 bjorn3 commented Aug 20, 2026

Copy link
Copy Markdown
Member

This makes it clear that it is only meant for LLVM intrinsics and not for defining or calling arbitrary user functions.

Follow up to #160077

@rustbot

rustbot commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator

compiler-builtins is developed in its own repository. If possible, consider making this change to rust-lang/compiler-builtins instead.

cc @tgross35

This PR changes rustc_public

cc @oli-obk, @celinval, @ouz-a, @makai410

miri is developed in its own repository. If the Miri part of this change can be broken out, consider making this change to rust-lang/miri instead. However, if Miri needs adjusting for rustc changes, just ignore this message.

cc @rust-lang/miri

stdarch is developed in its own repository. If possible, consider making this change to rust-lang/stdarch instead.

cc @Amanieu, @folkertdev, @sayantn

@rustbot rustbot added A-compiler-builtins Area: compiler-builtins (https://github.com/rust-lang/compiler-builtins) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 20, 2026
@rustbot rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 20, 2026
@rustbot

rustbot commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: libs
  • libs expanded to 12 candidates
  • Random selection from JohnTitor, Mark-Simulacrum, clarfonthey, nia-e, tgross35

@bjorn3 bjorn3 mentioned this pull request Aug 20, 2026
Merged
RalfJung
RalfJung reviewed Aug 20, 2026
View reviewed changes
Comment thread compiler/rustc_feature/src/removed.rs Outdated
RalfJung
RalfJung approved these changes Aug 20, 2026
View reviewed changes

@RalfJung RalfJung left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it. :)
I only carefully looked at the Miri parts, those LGTM.

View changes since this review

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bjorn3
bjorn3 force-pushed the rename_unadjusted_abi branch from 515519e to 130b07c Compare August 20, 2026 14:17
fbstj
fbstj reviewed Aug 20, 2026
View reviewed changes
Comment thread compiler/rustc_abi/src/extern_abi.rs Outdated
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bjorn3
bjorn3 force-pushed the rename_unadjusted_abi branch from 130b07c to e21f4cf Compare August 20, 2026 15:04
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bjorn3
bjorn3 force-pushed the rename_unadjusted_abi branch from 5b23cd8 to c0dd7fd Compare August 21, 2026 13:38
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-bors

This comment has been minimized.

Sign in to view
@bjorn3
bjorn3 force-pushed the rename_unadjusted_abi branch from c0dd7fd to 001d6e4 Compare August 27, 2026 10:23
@bjorn3
bjorn3 force-pushed the rename_unadjusted_abi branch from 001d6e4 to 3f09e9e Compare August 27, 2026 10:26
@bjorn3

bjorn3 commented Aug 27, 2026

Copy link
Copy Markdown
Member Author

CI passed. @tgross35 would you be able to take a look soon. This PR is fairly large, so it may be a bit bitrot prone.

tgross35
tgross35 approved these changes Aug 27, 2026
View reviewed changes

@tgross35 tgross35 left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from the standpoint of this just being a renaming, but we should make sure the regular stdarch maintainers are aware.

@folkertdev @adamgemmell @sayantn is stdarch reasonably up to date with r-l/r so this isn't going to cause conflicts with the next sync?

(r=me after one of them confirm)

@bors rollup=iffy p=5

View changes since this review

@folkertdev

folkertdev commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Yes, this shouldn't cause any (large) issues

@bors r=tgross35

@rust-bors

rust-bors Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 3f09e9e has been approved by tgross35

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 27, 2026
@tgross35

tgross35 commented Aug 27, 2026

Copy link
Copy Markdown
Member

Bors preserves iffy/never but doesn't preserve priority?

@bors p=5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RalfJung RalfJung RalfJung approved these changes
@tgross35 tgross35 tgross35 approved these changes
+1 more reviewer
@fbstj fbstj fbstj left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@tgross35 tgross35

Labels

A-compiler-builtins Area: compiler-builtins (https://github.com/rust-lang/compiler-builtins) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@bjorn3 @rustbot @rust-log-analyzer @folkertdev @tgross35 @fbstj @RalfJung