Constify Extend and FromIterator - #161500
Conversation
|
r? @JohnTitor rustbot has assigned @JohnTitor. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
fdf0b5e to
e613e35
Compare
This comment has been minimized.
This comment has been minimized.
e613e35 to
751b284
Compare
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
There was a problem hiding this comment.
I think this should also be constified, right?
There was a problem hiding this comment.
It is? It's inside const trait.
There was a problem hiding this comment.
Though the current doesn't allow to call iter.into_iter() which is less usable. I think we should also make a change like extend(), no?
There was a problem hiding this comment.
Ah, you mean const impl? Yeah, makes sense
There was a problem hiding this comment.
I've added the same bounds and constified impl for tuples.
This is part of an attempt to fully constify
Iterator. Specifically, I'm extracting the changes from the local branch that contains more or less minimal Iterator constification.