open issues when scheduled linkcheck fails - #2993
Conversation
rustbot
added
the
S-waiting-on-review
There was a problem hiding this comment.
Concept wise this seems like a good idea so broken links actually show up somewhere. Unsure about the third-party action picked since it doesn't really see much usage?
^ I don't care if the impl is GHA or Rust crate since I don't think it really matters, it's more about the action used specifically
|
|
||
| - name: Open an issue or comment on an existing one | ||
| id: report | ||
| uses: drivendataorg/failed-build-issue-action@940568ce50eeef3f31a920614cefcc6102d2f930 # v1.3.0 |
There was a problem hiding this comment.
Hm. I don't love a dependency on a not well-known GHA action (https://github.com/drivendataorg/failed-build-issue-action) 🤔
There was a problem hiding this comment.
Unsure about the third-party action picked since it doesn't really see much usage?
yeah, it's either this or write our own thing on top of the gh CLI, unfortunately there don't seem to be a lot of libraries for this. i can rewrite this on gh if you prefer.
There was a problem hiding this comment.
I think it's probably preferrable if we could do it based on gh 👍
There was a problem hiding this comment.
ok, rewrote it around that. i'll be honest the code is a big heaping pile of LLM bullshit, but it's not any worse than the GHA YAML.
- identify issues by label and title - reuse an existing issue if it already exists - use a bash script around `gh` so we don't add unvetted dependencies - add tests for the bash script using a fake `gh` mock
2df922a to
e90126e
Compare
3 participants
fixes #1956.
see jyn514#2 for example issues/comments it creates.
see https://github.com/rust-lang/rustc-dev-guide/actions/runs/33242644181/job/99074488060 for an example of the failures it'll link.
disclosure: most of the GHA crap here was generated by an LLM; it also found the GHA library, with prompting. i wrote the comments and PR description, and tested manually on my fork that it works.
i used an Action mostly because it seemed easy. i could port this to a Rust crate if you think it's better, seems mildly annoying to maintain but i don't feel strongly.
r? @jieyouxu