Skip to content

Only create a URL when opening docs with URI fragments #5036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChrisDenton merged 1 commit into from
Aug 27, 2026
+15 −5
Merged

Only create a URL when opening docs with URI fragments #5036

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions src/toolchain.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -523,11 +523,21 @@ impl<'a> Toolchain<'a> {
fragment: Option<&str>,
) -> anyhow::Result<()> {
let relative = relative.as_ref();
let mut doc_url = Url::from_file_path(self.doc_path(relative)?)
.ok()
.with_context(|| anyhow!("invalid doc file absolute path `{}`", relative.display()))?;
doc_url.set_fragment(fragment);
utils::open_browser(doc_url.to_string())
let doc_path = self.doc_path(relative)?;
// HACK: If a fragment is needed then turn the path into a url
// We avoid doing this if a fragment isn't needed because
// `open_browser` can call `ShellExecuteW` on Windows which doesn't
// handle urls very well. See #5035.
if fragment.is_some() {
let mut doc_url = Url::from_file_path(&doc_path).ok().with_context(|| {
anyhow!("invalid doc file absolute path `{}`", relative.display())
})?;
doc_url.set_fragment(fragment);
utils::open_browser(doc_url.to_string())
} else {
// Otherwise use the filesystem path.
utils::open_browser(&doc_path)
}
}

/// Remove the toolchain from disk
Expand Down
Loading