Skip to content

Add parallel iteration for exact chunks#1601

Open
Choudhry18 wants to merge 1 commit into
rust-ndarray:masterfrom
Choudhry18:parallel-exact-chunks
Open

Add parallel iteration for exact chunks#1601
Choudhry18 wants to merge 1 commit into
rust-ndarray:masterfrom
Choudhry18:parallel-exact-chunks

Conversation

@Choudhry18

Copy link
Copy Markdown

Implement Rayon IntoParallelIterator support for ExactChunks and ExactChunksMut by wrapping their NdProducer traversal in an unindexed parallel producer. Add coverage for immutable and mutable exact chunk iteration and document the new API.

Closes #1192

Implement Rayon IntoParallelIterator support for ExactChunks and ExactChunksMut by wrapping their NdProducer traversal in an unindexed parallel producer. Add coverage for immutable and mutable exact chunk iteration and document the new API.

Closes rust-ndarray#1192
@nilgoyette

Copy link
Copy Markdown
Collaborator

This is not a critic of your code (I haven't checked), but I wonder if we actually want a _par version of our functions. I mean, it will double our API. However, most (all?) iterators/producers can be used with Zip::par_*. Are you telling me thatExactChunks can't?

Sorry @akern40 to disturb you :) Do you have an opinion on this _par matter?

@Choudhry18

Copy link
Copy Markdown
Author

ExactChunks can be used with Zip::par the comment on the issue also mentions that. My understanding was that we would want to add the _par versions for consistency as AxisIter and AxisChunksIter both have _par versions when they can also be used with Zip::par

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Exact Chunks Parallel Iterator

2 participants