Conversation
new_boxed derives the allocation layout from tag_size, but derives the Box's fat pointer from T::dst_len(&header), which reads the size back from the header. If Header::set_size stores the size lossily (e.g. truncates it to a smaller integer), the two disagree. Protect against that.
The MaybeDynSized contract documents BASE_SIZE as the true structure size without any implicit padding.
The resolution and character_size fields were Rust tuples inside the repr(C, packed) struct. Tuples are repr(Rust) and have no layout guarantee.
e/session_01GcU1hQr2jcCBdCtFgJshca
Remove it so the deprecated getter behaves exactly like the elf_sections_tag()/sections() path it is documented to be replaced by.
The framebuffer serialization path was fixed a while ago; the whole builder test runs cleanly under Miri. The leftover comment wrongly suggests a known, unfixed soundness issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.