[3.0.0 prep] Lossy error messages - #404
Merged
Merged
Conversation
cicku
force-pushed
the
lossy-error-messages
branch
from
August 24, 2026 04:33
236e4bb to
e874e61
Compare
cicku
force-pushed
the
lossy-error-messages
branch
from
August 31, 2026 21:19
e874e61 to
2fbf203
Compare
cicku
marked this pull request as ready for review
September 1, 2026 15:58
Collaborator
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discovered when writing tests for #403, w/ long non-ASCII paths. At 376 chars (976 UTF-8 bytes),
std::fscreated and read the file happily, but the crate failed with:The issue exists in 2.5.0, but due to edition bump, PR must be merged after #400, and a rebase will be done then.