[3.0.0 prep] Async packet sink (sending) - #405
Open
cicku wants to merge 2 commits into
Open
Conversation
cicku
force-pushed
the
async-packet-sink
branch
2 times, most recently
from
August 24, 2026 19:42
1c75fa5 to
1918e47
Compare
cicku
force-pushed
the
async-packet-sink
branch
from
August 31, 2026 21:19
1918e47 to
1a3320b
Compare
cicku
force-pushed
the
async-packet-sink
branch
from
September 2, 2026 16:51
1a3320b to
d7c65d2
Compare
cicku
marked this pull request as ready for review
September 4, 2026 05:03
cicku
marked this pull request as draft
September 4, 2026 15:52
cicku
marked this pull request as ready for review
September 4, 2026 15:57
Contributor
Author
|
This PR is only for sending packets - However, if #344 is looking for a singular solution, we can either:
|
cicku
changed the title
Wojtek242
requested changes
Sep 6, 2026
Wojtek242
left a comment
Wojtek242
left a comment
Collaborator
There was a problem hiding this comment.
Tiny comment about a "magic constant"
| // Linux can be any executor, as it holds nothing of tokio's; 128 is what tokio allows | ||
| // a task between yields. Spending the task's budget as well holds a task that also | ||
| // does tokio I/O to one budget between yields rather than one for each source. | ||
| if self.sent_since_yield == 128 { |
Collaborator
There was a problem hiding this comment.
Define 128 somewhere as a const with a self-explanatory name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #373.