fix: improving font rendering and visually consistent and meet accessibility guidelines for contrast - #248
Open
cw1997 wants to merge 2 commits into
Open
fix: improving font rendering and visually consistent and meet accessibility guidelines for contrast#248cw1997 wants to merge 2 commits into
cw1997 wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
This pull request standardizes and improves the styling and accessibility of all solid "danger" (destructive confirm) buttons across the application. It introduces a shared
DANGER_BUTTON_CLASSto ensure consistent use of the correct background and foreground colors for destructive actions, addressing previous issues where labels on red buttons were unreadable or inconsistent. The change also registers and applies a new--destructive-foregroundCSS variable for proper contrast in both light and dark themes. Additionally, the font stacks are enhanced for better internationalization support.Danger button standardization and accessibility:
DANGER_BUTTON_CLASSincomponents/danger-button.tsfor solid danger buttons, ensuring consistent styling and label color across all destructive confirmation dialogs and actions.--destructive-foregroundCSS variable inapp/globals.cssfor both light and dark themes, providing accessible contrast for button labels. [1] [2] [3]text-whiteand custom bg/text pairs) withDANGER_BUTTON_CLASSin all relevant components and dialogs, including SSE dialogs, object delete, and shared dialog host. [1] [2] [3] [4] [5] [6] [7] [8]Font stack and internationalization improvements:
app/globals.cssto provide better fallbacks for Latin, Han, Kana, Hangul, and Arabic scripts, including language-specific overrides for Japanese and Korean. [1] [2]These changes ensure that all destructive confirm buttons are both visually consistent and meet accessibility guidelines for contrast, while also improving font rendering for international users.
Type of Change
Testing
Checklist
Related Issues
Closes #
Screenshots (if applicable)
Additional Notes