feat(driver): expose per-shard io-wq registration results - #17
Merged
Merged
Conversation
Co-Authored-By: heihutu <heihutu@gmail.com> Co-Authored-By: zhi22915 <qiuzgang@gmail.com>
Co-Authored-By: heihutu <heihutu@gmail.com> Co-Authored-By: zhi22915 <qiuzgang@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Related to rustfs/backlog#2647, step 4.2.iowq. This reports the existing io-wq startup request; it does not change worker limits or close the application-wide budget item.
Summary of Changes
[16, 0]io-wq registration request and result during startup.shard_iowq_setup()in shard order. Successful registration records the kernel-returned previous limits; failure records the I/O error kind and optional errno.Verification
cargo check --locked --all-targets --all-featurespassed.cargo clippy --locked --all-targets --all-features -- -D warningspassed.cargo fmt --all --checkandgit diff --checkpassed.193ab21passed all three jobs: 147 native all-feature tests, mandatory O_DIRECT, ordered-prefetch and both benchmark correctness smokes, and restricted/unrestricted Docker coverage. The new three injected unit tests and two-shard native test executed with no skip. The documentation-only final head2b79358also passed all three CI jobs.Impact
Registration still requests sixteen bounded workers per NUMA node and leaves the unbounded class unchanged. Failure remains nonfatal. The recorded previous limits are historical values, not effective limits or active worker counts; no process-wide cap or performance gain is claimed. Existing constructors and dependency features are unchanged.
Additional Notes
This PR is independently revertible. No data or configuration migration is required. Application dependency wiring, result memory limits, and resource-isolated performance acceptance remain separate work.