Fix missing rich.markup.escape import in tools/ci.py#69408
Open
dwoz wants to merge 1 commit into
Open
Conversation
Commit fffeee3 ("Run pre-commit twice in dependabot sync") added escape(...) calls at 9 locations in tools/ci.py but did not add the import. Since that change merged via a58c4dc on 2026-06-09, every push to 3006.x and every PR targeting 3006.x fails at "Prepare Workflow Run" with NameError: name 'escape' is not defined. Importing escape from rich.markup unblocks CI for every 3006.x PR. 3007.x already has this import at tools/ci.py:21.
Contributor
Author
|
This PR is redundant. The missing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit
fffeee3f235("Run pre-commit twice in dependabot sync") addedescape(...)calls at 9 locations intools/ci.pybut did not add the import. Since that change merged viaa58c4dcd602on 2026-06-09, every push to3006.xand every PR targeting3006.xfails at Prepare Workflow Run with:Importing
escapefromrich.markupunblocks CI for every open 3006.x PR.3007.xalready has this exact import attools/ci.py:21.This same fix is also bundled inside #69403 as commit
4ca3e1bd7a7, but #69403 has other in-progress changes including a regression insalt/states/file.py::test_managed. Landing the escape fix standalone here unblocks the CI fleet without waiting on #69403's other concerns.