Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions lib/utilities/collectResponseHeaders.js
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,12 @@ function collectResponseHeaders(objectMD, corsHeaders, versioningCfg, returnTagC
}
if (objectMD.replicationInfo) {
const { isReplica, status } = objectMD.replicationInfo;
if (isReplica || status) {
responseMetaHeaders['x-amz-replication-status'] = isReplica ? 'REPLICA' : status;
if (isReplica) {
const hasReplicated = !status || status === 'COMPLETED';
responseMetaHeaders['x-amz-replication-status'] = hasReplicated ? 'REPLICA' : status;
responseMetaHeaders['x-amz-meta-scal-replica'] = 'true';
} else if (status) {
responseMetaHeaders['x-amz-replication-status'] = status;
Comment thread
maeldonn marked this conversation as resolved.
}
}
if (Array.isArray(objectMD?.replicationInfo?.backends)) {
Expand Down
38 changes: 36 additions & 2 deletions tests/unit/utils/collectResponseHeaders.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,46 @@ describe('Middleware: Collect Response Headers', () => {
assert.deepStrictEqual(headers['x-amz-replication-status'], 'REPLICA');
});

it('should set REPLICA header from isReplica even when status is PENDING', () => {
it('should mark a replica with x-amz-meta-scal-replica', () => {
const objectMD = {
replicationInfo: { status: 'PENDING', isReplica: true },
replicationInfo: { status: 'REPLICA', isReplica: true },
};
const headers = collectResponseHeaders(objectMD);
assert.deepStrictEqual(headers['x-amz-replication-status'], 'REPLICA');
assert.deepStrictEqual(headers['x-amz-meta-scal-replica'], 'true');
});

it('should default to REPLICA when isReplica is true and status is absent', () => {
const objectMD = { replicationInfo: { isReplica: true } };
const headers = collectResponseHeaders(objectMD);
assert.deepStrictEqual(headers['x-amz-replication-status'], 'REPLICA');
assert.deepStrictEqual(headers['x-amz-meta-scal-replica'], 'true');
});

['PENDING', 'PROCESSING', 'FAILED'].forEach(status => {
it(`should expose onward status ${status} on a cascaded replica`, () => {
const objectMD = { replicationInfo: { status, isReplica: true } };
const headers = collectResponseHeaders(objectMD);
assert.deepStrictEqual(headers['x-amz-replication-status'], status);
assert.deepStrictEqual(headers['x-amz-meta-scal-replica'], 'true');
});
});

it('should report REPLICA once onward replication is COMPLETED', () => {
const objectMD = {
replicationInfo: { status: 'COMPLETED', isReplica: true },
};
const headers = collectResponseHeaders(objectMD);
assert.deepStrictEqual(headers['x-amz-replication-status'], 'REPLICA');
assert.deepStrictEqual(headers['x-amz-meta-scal-replica'], 'true');
});
Comment thread
maeldonn marked this conversation as resolved.

it('should not mark x-amz-meta-scal-replica when not a replica', () => {
const objectMD = {
replicationInfo: { status: 'PENDING', isReplica: false },
};
const headers = collectResponseHeaders(objectMD);
assert.deepStrictEqual(headers['x-amz-meta-scal-replica'], undefined);
});

it('should use replicationInfo.status when isReplica is false', () => {
Expand Down
Loading