ci: align the PR review on the shared skill - #25
Open
ezekiel-alexrod wants to merge 2 commits into
Open
Conversation
A reusable workflow inherits no secret: the review job only sees what the caller lists under `secrets:`. Without `ACTIONS_APP_PRIVATE_KEY` the shared workflow skips the agent-hub marketplace, so the `scality-skills` plugin is never loaded and its `/review-pr` skill is unavailable.
The `/review-pr` skill of the `scality-skills` plugin reads its criteria from `.claude/REVIEW.md`, so the repo only has to describe what matters here. Keeping a fork of the whole skill freezes its mechanics: this copy predates the check-run summary and the helper scripts, and it still signs comments and posts a summary comment, both of which the current skill forbids. The criteria table moves over unchanged — it was the only repo-specific part of the fork. The steps, the posting commands and the output modes now come from upstream and stay up to date on their own.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The review job never received
ACTIONS_APP_PRIVATE_KEY. A reusable workflowinherits no secret, so the shared workflow skipped the agent-hub marketplace and
the
scality-skillsplugin was never loaded. Until now the repo-local fork of the/review-prskill covered for that — which is why nobody noticed.Passing the key lets the plugin load, so the fork is no longer needed. The current
skill reads its criteria from
.claude/REVIEW.md, so the repo keeps only what isrepo-specific and stops carrying a copy of the mechanics. The fork here predates the
check-run summary and the helper scripts, and it still signs comments and posts a
summary comment — both forbidden by the current skill.
The criteria table moves over unchanged, row for row. What disappears is the
argument parsing, the
ghcommands and the output modes, which now come fromupstream and stay up to date on their own.
Visible change after merge: the summary becomes a
Claude Code Reviewcheck runinstead of a
Review by Claude Codecomment, and inline comments lose the— Claude Codesignature.Validated end to end on scality/image-cache#7: check run posted, and no
"No review instructions found" note, which proves the criteria file was read.