Handle deleted GH user - #92
Merged
jarrodmillman merged 2 commits intoSep 17, 2026
Merged
Conversation
Member
|
Looks like an OK workaround to me. @lagru could we merge this or something similar and do a release? |
lagru
self-requested a review
September 13, 2026 16:28
lagru
reviewed
Sep 15, 2026
| reference_url=user.html_url, | ||
| ) | ||
| ) | ||
| except GithubException as error: |
Member
There was a problem hiding this comment.
@jarrodmillman do you have a repository and set of commits for me so that I can reproduce the error?
I've tweaked below to use the logger rather than a print statement. Otherwise this fix seems good to go to me.
Though, the proper fix might be to handle deleted users gracefully and propagate that to the release notes properly.
Member
There was a problem hiding this comment.
The current main from the networkx repo has a user who no longer exists in github.
That's where we ran into it. Changelist from version 3.6 to main.
lagru
approved these changes
Sep 15, 2026
Member
|
Waiting a bit for feedback, otherwise I'll merge. |
jarrodmillman
force-pushed
the
handle-missing-user
branch
from
September 17, 2026 21:01
0aa2199 to
c969948
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This just catches the missing user and prints a warning. We should probably do something else, but I made this PR to get feedback.