OKD-380: Add missing namespace to image trigger annotations

[pskrbasu]

Problem

Deploying PostgreSQL from the OKD 4.22 Software Catalog fails with:

spec.containers[0].image: Invalid value: " ": must not have leading or trailing whitespace

Reported in okd-project/okd#2337

Root Cause

When templates were migrated from DeploymentConfig to Deployment, the image.openshift.io/triggers annotation dropped the namespace field from the ImageStreamTag reference. Without it, the image trigger controller defaults to the Deployment's own namespace instead of openshift, so it can't find the ImageStream and the container image is never resolved.

Fix

Add "namespace":"${NAMESPACE}" to the trigger annotation's from object in both postgresql-persistent and postgresql-ephemeral templates. The NAMESPACE parameter already exists in both templates with a default value of "openshift".

Impact

These template files are the upstream source for openshift/library (via make import) and ultimately openshift/cluster-samples-operator. An immediate fix was applied directly to the operator in openshift/cluster-samples-operator#701. This upstream fix ensures the bug doesn't recur on the next sync.

Summary by CodeRabbit

• Chores
  • Updated PostgreSQL template configurations to include explicit namespace specifications for container image resolution in OpenShift environments, improving deployment reliability.

[coderabbitai]

📝 Walkthrough

Walkthrough

Both OpenShift PostgreSQL template files (postgresql-ephemeral-template.json and postgresql-persistent-template.json) are updated to add a "namespace":"${NAMESPACE}" field to the ImageStreamTag reference inside the Deployment's image.openshift.io/triggers annotation.

Changes

ImageStreamTag Namespace in Deployment Triggers

Layer / File(s)	Summary
Add namespace to ImageStreamTag trigger annotations examples/postgresql-ephemeral-template.json, examples/postgresql-persistent-template.json	The image.openshift.io/triggers annotation on the Deployment object in both templates is updated so the referenced ImageStreamTag now includes "namespace": "${NAMESPACE}", where previously no namespace was specified.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A rabbit hops through template land,
Where namespaces were left unplanned.
🐇 Now ${NAMESPACE} joins the tag,
No more lost streams left to drag.
Each trigger knows just where to look! 🎯

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically summarizes the main change: adding missing namespace fields to image trigger annotations in the two PostgreSQL template files.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

Pull Request validation

Failed

🔴 Review - Missing review from a member (1 required)

Success

🟢 CI - All checks have passed

---

Triggered by Workflow Run

[phracek]

[test-openshift-pytest]

[phracek]

LGTM. Thanks.

[github-actions]

Testing Farm results

name	compose	arch	status	started (UTC)	time	logs
RHEL10 - PyTest - OpenShift 4 - 18	RHEL-10.2-Nightly	x86_64	✅ passed	23.06.2026 08:53:15	17min 18s	test pipeline
RHEL8 - PyTest - OpenShift 4 - 15	RHEL-8.10.0-Nightly	x86_64	✅ passed	23.06.2026 10:32:12	28min 53s	test pipeline
RHEL8 - PyTest - OpenShift 4 - 13	RHEL-8.10.0-Nightly	x86_64	✅ passed	23.06.2026 10:32:12	21min 28s	test pipeline
RHEL9 - PyTest - OpenShift 4 - 18	RHEL-9.8.0-Nightly	x86_64	✅ passed	23.06.2026 09:13:11	28min 26s	test pipeline
RHEL9 - PyTest - OpenShift 4 - 16	RHEL-9.8.0-Nightly	x86_64	✅ passed	23.06.2026 10:32:11	34min 57s	test pipeline
RHEL9 - PyTest - OpenShift 4 - 15	RHEL-9.8.0-Nightly	x86_64	✅ passed	23.06.2026 10:32:14	32min 44s	test pipeline
RHEL8 - PyTest - OpenShift 4 - 12	RHEL-8.10.0-Nightly	x86_64	✅ passed	23.06.2026 10:32:13	23min 3s	test pipeline
RHEL8 - PyTest - OpenShift 4 - 16	RHEL-8.10.0-Nightly	x86_64	✅ passed	23.06.2026 10:32:13	23min 27s	test pipeline
RHEL9 - PyTest - OpenShift 4 - 13	RHEL-9.8.0-Nightly	x86_64	✅ passed	23.06.2026 10:32:11	30min 42s	test pipeline
RHEL10 - PyTest - OpenShift 4 - 16	RHEL-10.2-Nightly	x86_64	✅ passed	23.06.2026 10:32:13	31min 36s	test pipeline