Consolidate Single and Multi Table Reports - #2928
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2928 +/- ##
==========================================
- Coverage 98.08% 98.07% -0.02%
==========================================
Files 73 75 +2
Lines 8531 8587 +56
==========================================
+ Hits 8368 8422 +54
- Misses 163 165 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| @@ -0,0 +1,344 @@ | |||
| from unittest.mock import Mock, patch | |||
There was a problem hiding this comment.
Could we add some integration tests to make sure the warnings are raised? In addition, we should add integration tests to make sure the new functions work as expected.
There was a problem hiding this comment.
@pvk-developer Could we add integration tests for the happy path? Where the user uses the new namespace with valid inputs?
from sdv.evaluation import run_diagnostic, evaluate_quality
diagnostic_report = run_diagnostic(
real_data=real_data,
synthetic_data=synthetic_data,
metadata=metadata)
quality_report = evaluate_quality(
real_data=real_data,
synthetic_data=synthetic_data,
metadata=metadata)I don't see that. I only see the integration tests to make sure the FutureWarning shows up.
…e-reports-into-one
Resolves #2923
CU-86batre16
This pr also updates the visualization functions.