Skip to content

Consolidate Single and Multi Table Reports - #2928

Merged
pvk-developer merged 10 commits into
mainfrom
issue-2923-consolidate-single-and-multi-table-reports-into-one
Jul 23, 2026
Merged

Consolidate Single and Multi Table Reports#2928
pvk-developer merged 10 commits into
mainfrom
issue-2923-consolidate-single-and-multi-table-reports-into-one

Conversation

@pvk-developer

Copy link
Copy Markdown
Member

Resolves #2923
CU-86batre16

This pr also updates the visualization functions.

@pvk-developer
pvk-developer requested a review from a team as a code owner July 21, 2026 13:12
@pvk-developer
pvk-developer requested review from frances-h and removed request for a team July 21, 2026 13:12
@sdv-team

Copy link
Copy Markdown
Contributor

@pvk-developer pvk-developer self-assigned this Jul 21, 2026
@pvk-developer
pvk-developer requested a review from gsheni July 21, 2026 13:12
@codecov

codecov Bot commented Jul 21, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 98.07%. Comparing base (5dcdba3) to head (78b17a5).

Files with missing lines Patch % Lines
sdv/evaluation/multi_table.py 91.66% 1 Missing ⚠️
sdv/evaluation/single_table.py 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2928      +/-   ##
==========================================
- Coverage   98.08%   98.07%   -0.02%     
==========================================
  Files          73       75       +2     
  Lines        8531     8587      +56     
==========================================
+ Hits         8368     8422      +54     
- Misses        163      165       +2     
Flag Coverage Δ
integration 76.48% <91.66%> (+0.09%) ⬆️
unit 97.06% <96.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@@ -0,0 +1,344 @@
from unittest.mock import Mock, patch

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add some integration tests to make sure the warnings are raised? In addition, we should add integration tests to make sure the new functions work as expected.

@gsheni gsheni Jul 22, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pvk-developer Could we add integration tests for the happy path? Where the user uses the new namespace with valid inputs?

from sdv.evaluation import run_diagnostic, evaluate_quality

diagnostic_report = run_diagnostic(
    real_data=real_data,
    synthetic_data=synthetic_data,
    metadata=metadata)

quality_report = evaluate_quality(
    real_data=real_data,
    synthetic_data=synthetic_data,
    metadata=metadata)

I don't see that. I only see the integration tests to make sure the FutureWarning shows up.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to commit the file... e5378a4

@pvk-developer
pvk-developer requested a review from gsheni July 22, 2026 14:31
@pvk-developer
pvk-developer merged commit 2a708f5 into main Jul 23, 2026
47 checks passed
@pvk-developer
pvk-developer deleted the issue-2923-consolidate-single-and-multi-table-reports-into-one branch July 23, 2026 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consolidate single and multi-table evaluation reports into one

4 participants