layers/bluetooth: Add an HCI_Event_Vendor handler registration mechanism - #5080
Open
antoniovazquezblanco wants to merge 1 commit into
Open
layers/bluetooth: Add an HCI_Event_Vendor handler registration mechanism#5080antoniovazquezblanco wants to merge 1 commit into
antoniovazquezblanco wants to merge 1 commit into
Conversation
antoniovazquezblanco
force-pushed
the
evtvendor
branch
from
August 10, 2026 12:54
f805529 to
c25abd5
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5080 +/- ##
==========================================
+ Coverage 79.42% 80.59% +1.16%
==========================================
Files 372 390 +18
Lines 96507 96877 +370
==========================================
+ Hits 76652 78076 +1424
+ Misses 19855 18801 -1054
🚀 New features to boost your workflow:
|
antoniovazquezblanco
force-pushed
the
evtvendor
branch
from
August 10, 2026 13:00
c25abd5 to
7d05f1b
Compare
antoniovazquezblanco
force-pushed
the
evtvendor
branch
from
August 20, 2026 14:46
7d05f1b to
1fc64d2
Compare
Contributor
Author
|
Rebased for tests to pass :) |
gpotter2
reviewed
Aug 25, 2026
gpotter2
left a comment
gpotter2
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR & sorry for the delay !
Comment on lines
+2812
to
+2826
| def default_payload_class(self, payload): | ||
| for handler_cls, check in ( | ||
| HCI_Event_Vendor.registered_handlers.items() | ||
| ): | ||
| if check(payload): | ||
| return handler_cls | ||
|
|
||
| return Packet.default_payload_class(self, payload) | ||
|
|
||
| def do_dissect(self, s): | ||
| if s and self.default_payload_class(s) is not conf.raw_layer: | ||
| self.raw_packet_cache = None | ||
| self.explicit = 1 | ||
| return s | ||
| return super(HCI_Event_Vendor, self).do_dissect(s) |
Member
There was a problem hiding this comment.
Couldn't this be replaced with a dispatch_hook ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Inspired by EIR_Manufacturer_Specific_Data magic payload registration.