Harden CI: Artifactory OIDC, NuGet lockfiles, tightened permissions - #146
Open
MichaelGHSeg wants to merge 7 commits into
Open
MichaelGHSeg wants to merge 7 commits into
MichaelGHSeg wants to merge 7 commits into
Conversation
- Add Artifactory OIDC composite action (configures NuGet to use virtual-nuget-thirdparty) - Add ci.yml: fork-aware, dotnet build/test, --locked-mode, SHA-pinned actions - Add deploy.yml: tag-triggered, environment: nuget gate, tightened permissions - Add Directory.Build.props to enable NuGet lockfiles repo-wide - Add packages.lock.json for Analytics-CSharp and Tests projects - Update e2e-tests.yml: remove E2E_TESTS_TOKEN, fork-aware
![semgrep-code-segmentio-2[bot]](https://avatars.githubusercontent.com/u/819518?s=60&v=4){kind=small}
didiergarcia
previously approved these changes
Jul 10, 2026
Rewrite composite action to use single-script pattern matching
analytics-python: audience=${ARTIFACTORY_URL}, provider_name=
github-actions-segmentio, and add JWT claim logging for debugging.
Replaces the repo-local copy with the shared first-party action, pinned. Each SDK had its own drifting copy of the same exchange; the shared one covers every ecosystem we use, so fixes land once instead of six times.
The job declared 'nuget', which does not exist. NUGET_API_KEY is an environment secret on 'deployment', and environment secrets are only visible to jobs using that exact environment — so secrets.NUGET_API_KEY resolved to empty and GitHub silently created an unprotected 'nuget' environment on first run. Pointing at 'deployment' rather than renaming keeps the existing secret in place; its value cannot be read back to recreate it elsewhere.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Notes
Test plan