Harden CI: Artifactory OIDC, fork-aware workflows, composer.lock - #253
Merged
Merged
Conversation
- Add Artifactory OIDC composite action (configures Composer to use virtual-php-thirdparty) - Add ci.yml: fork-aware, PHP 8.1-8.4 matrix, --no-scripts, SHA-pinned actions - Update e2e-tests.yml: remove E2E_TESTS_TOKEN, fork-aware - Commit composer.lock (removed from .gitignore)
![semgrep-code-segmentio-2[bot]](https://avatars.githubusercontent.com/u/819518?s=60&v=4){kind=small}
didiergarcia
previously approved these changes
Jul 10, 2026
Rewrite composite action to use single-script pattern matching
analytics-python: audience=${ARTIFACTORY_URL}, provider_name=
github-actions-segmentio, and add JWT claim logging for debugging.
The pinned SHAs for setup-ruby/setup-php/codecov/release-gem did not exist upstream, so the org's sha_pinning_required check could never resolve them. Repinned to the commits the v1/v2/v5 tags actually point at.
The org Actions policy admits GitHub-owned actions only, so shivammathur/setup-php could never resolve and every workflow referencing it failed at startup with no check reported. The runner image ships exactly one PHP, so CI can only prove that one. PHP_MATRIX/PHP_PRIMARY hold the version list in one place and feed all three matrix jobs, so restoring breadth is a one-line change once LIBRARIES-3169 settles how other versions get installed. The local setup-php action verifies the runtime rather than installing it, and fails loudly on a version the image lacks so a widened matrix cannot silently test the wrong runtime. cs2pr and codecov upload go with it — both came from blocked actions. The PHPCS report and clover.xml are kept as build artifacts instead.
Bare ubuntu-latest never gets picked up on same-repo PRs here, so the job sat queued and held the whole workflow behind it.
The lock had doctrine/instantiator 2.1.0, which requires PHP ^8.4, so it was installable only on 8.4 — every other leg of the matrix would have failed had CI ever started. Nothing else in the lock needs above 8.1. config.platform.php makes resolution independent of whoever regenerates the lock, and 8.1 keeps it installable across the full intended 8.1-8.4 matrix rather than just the version CI currently runs. It constrains this project's own resolution only; consumers still resolve against their own runtime.
Replaces the repo-local copy with the shared first-party action, pinned. Each SDK had its own drifting copy of the same exchange; the shared one covers every ecosystem we use, so fixes land once instead of six times.
wenxi-zeng
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Notes
Test plan