[UIK-5830][d3-chart] Rebranding - #3160
Open
j-mnizhek wants to merge 10 commits into
Open
Conversation
j-mnizhek
marked this pull request as ready for review
September 1, 2026 12:07
…chart-tooltip-rebranding Signed-off-by: Julia Mnizhek <77798437+j-mnizhek@users.noreply.github.com>
slizhevskyv-semrush
requested review from
ilyabrower and
slizhevskyv-semrush
September 8, 2026 11:02
ilyabrower
reviewed
Sep 8, 2026
|
|
||
| if (value instanceof Date) { | ||
| return value.toDateString(); | ||
| return new Intl.DateTimeFormat('en', { |
Contributor
There was a problem hiding this comment.
'en' -> locale from props, i think?
| return tooltipValueFormatter(value); | ||
| } | ||
|
|
||
| private defaultTooltipFormatter(value?: unknown): string { |
Contributor
There was a problem hiding this comment.
probably this should be protected too...
|
|
||
| SPointShape[shape='Line'][size='l'] { | ||
| /* TODO: Remove */ | ||
| /* SPointShape[shape='Line'][size='l'] { |
| rgba(0, 0, 0, 0.48) 60%, | ||
| transparent 100% | ||
| ); | ||
| mask-image: linear-gradient(to bottom, #000 0%, rgba(0, 0, 0, 0.48) 60%, transparent 100%); |
Contributor
There was a problem hiding this comment.
not sure we need both -webkit-* and mask-image
| } | ||
|
|
||
| SDot[active] { | ||
| box-shadow: var(--intergalactic-box-shadow-chart-dot-elevated, 0px 0px 2px 0px oklch(0.137 0.026 175.7 / 0.161), 0px 1px 2px 0px oklch(0.137 0.026 175.7 / 0.161)); |
Contributor
There was a problem hiding this comment.
box-shadow won't work in svg circles
|
|
||
| SDot[active] { | ||
| box-shadow: var(--intergalactic-box-shadow-chart-dot-elevated, 0px 0px 2px 0px oklch(0.137 0.026 175.7 / 0.161), 0px 1px 2px 0px oklch(0.137 0.026 175.7 / 0.161)); | ||
| filter: drop-shadow(0px 0px 1px oklch(0.176 0.033 175.7 / 0.07)) drop-shadow(0px 1px 3px oklch(0.176 0.033 175.7 / 0.07)); |
Contributor
There was a problem hiding this comment.
not sure we will see this at all
| static style = style; | ||
| static defaultProps = {}; | ||
|
|
||
| measurer = new TextMeasurer(); |
Contributor
There was a problem hiding this comment.
maybe we can use one instance for all axis?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
How has this been tested?
Screenshots (if appropriate):
Types of changes
Checklist: