Show a better error message when the .proto descriptor is not available#1493
Open
mcruzdev wants to merge 1 commit into
Open
Show a better error message when the .proto descriptor is not available#1493mcruzdev wants to merge 1 commit into
mcruzdev wants to merge 1 commit into
Conversation
Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the failure mode when a gRPC .proto descriptor resource cannot be opened (previously resulting in a bare NullPointerException), aligning with issue #1492.
Changes:
- Add an explicit null-check for the
InputStreamreturned byExternalResourceHandler.open(). - Throw a clearer exception message when the
.protodescriptor resource is unavailable.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+44
to
+49
| if (inputStream == null) { | ||
| throw new IllegalStateException( | ||
| "Could not read gRPC proto descriptor resource '" | ||
| + externalResourceHandler.name() | ||
| + "'. Verify the path is correct and that the resource is available."); | ||
| } |
Comment on lines
+49
to
53
| } | ||
|
|
||
| Path protoFile = grpcDir.resolve(externalResourceHandler.name()); | ||
| if (!Files.exists(protoFile)) { | ||
| Files.createDirectories(protoFile); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many thanks for submitting your Pull Request ❤️!
What this PR does / why we need it:
Special notes for reviewers:
Additional information (if needed):
Closes #1492