cowrcstr: Remove unnecessary release assert. - #452
Merged
Conversation
Rust guarantees that slices are never bigger than isize::MAX. This came up because I was looking at whether it'd be possible to use one bit of the length field as a tag, and keep the str bytes as the pointer in the owned case too (so the conversion to str is just removing the tag). But that doesn't seem feasible unless we go to Rc<str> rather than Rc<String>, which would enforce reallocating the escaped strings, which is a bit annoying... So I'm not pursuing that for now.
jdm
approved these changes
Aug 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rust guarantees that slices are never bigger than isize::MAX.
This came up because I was looking at whether it'd be possible to use one bit of the length field as a tag, and keep the str bytes as the pointer in the owned case too (so the conversion to str is just removing the tag).
But that doesn't seem feasible unless we go to Rc rather than Rc, which would enforce reallocating the escaped strings, which is a bit annoying... So I'm not pursuing that for now.