chore: upgraded MSRV to 1.86, edition 2024, and criterion 0.8 - #507
Open
alejandro-vaz wants to merge 2 commits into
Open
chore: upgraded MSRV to 1.86, edition 2024, and criterion 0.8#507alejandro-vaz wants to merge 2 commits into
alejandro-vaz wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR upgrades the MSRV to 1.86 with edition 2024
the rationale for this decision is on #493
closes #493
it allows us to take advantage of the features introduced with edition 2024, and 1.86 was specifically chosen instead of 1.85 because many features that weren't ready for the release of edition 2024 were stabilized in this version
changes introduced
unsafeblocks had to be added inlib.rssince unsafe functions from edition 2024 onwards don't allow unsafe code to be executed without an explicit unsafe block