fix: refactor taggedlen/rawsmallvec and visibility - #512
Open
alejandro-vaz wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR refactors
TaggedLenandRawSmallVecexclusively to address visibility issuesRawSmallVecimplementation intorawsmallvec.rsTaggedLenand its implementations totaggedlen.rsRawSmallVecimplementation methods publicTaggedLento be exported under theinternalsfeatureRawSmallVecmethods are made public so they can be seen when exported under theinternalsfeature to downstream cratesconsequently,
TaggedLenneeds to be made public in order to allow thetry_grow_rawmethod inRawSmallVecto be public and callablenote:
borsh.rshas been changed in order not to use the first field, which was incorrect. using the first field also meant that it had to be made public but it is kept private. this is also implemented in #506 but I had to port it here