Conversation
|
No description provided. |
🚀 Quick Review App CommandsWelcome! Here are the commands you can use in this PR:
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (2)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. WalkthroughThe project updates React, React DOM, React Server Components, React on Rails Pro, and the Node renderer versions in ChangesReact on Rails dependency updates
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Other Merge Risk: ⚪ Minimal · up to The dependency upgrade is mergeable with no unresolved correctness or integration risk identified. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Some tools did not complete. Review the errors below. 🔧 ESLint
package.jsonParsing error: Missing semicolon. (2:8) Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Manual verification: registry-backed RC4Environment: fresh clone of Before / regression control: changing only After: restoring public Additional evidence: frozen Yarn install passed; all required output artifacts were nonempty; JS tests passed 16/16; live Browser environment note: the first local system-spec attempt was blocked before page load by a stale ChromeDriver 150 in PATH against Chrome 153. Excluding that stale executable allowed Selenium Manager to select the compatible driver, after which targeted and full browser-bearing suites passed. |
|
Review summaryThis PR is a mechanical dependency bump touching only Findings (left as inline comments):
No issues found in:
No security or correctness issues introduced by this diff itself beyond the general (acknowledged) risk of depending on pre-release packages. |
|
No description provided. |
Address-review summaryScan scope: full PR history through 2026-09-12T23:07:00Z (no earlier address-review checkpoint). Mattered
Skipped
All three inline review threads were replied to and resolved. Next default scan starts after this comment. Say |
|
Reviewed. This is a clean, self-contained dependency/lockfile bump — no application source changes, and I verified there are no other stale version references left behind (checked Two minor, non-blocking observations:
Nothing here blocks the merge — the lockfile changes look internally consistent ( |
Address-review summaryScan scope: review activity after the previous summary at 2026-09-12T23:09:04Z. Mattered
Optional
Skipped
All current-head checks are terminal and green, and all inline review threads are resolved. Next default scan starts after this comment. Say |
Summary
17.1.0.rc.3.17.1.0-rc.3.react-on-rails-rsc@19.3.0-rc.4with React, React DOM, and React Server DOM Webpack19.2.8.This is the downstream tutorial validation candidate for the empty
"use client"module fix from react-on-rails-rsc issue #823 / PR #230.Manual verification
Regression control
With the same dependency set except
react-on-rails-rsc@19.3.0-rc.3,yarn build:devreproduced the expected failure:After restoring the registry-published
react-on-rails-rsc@19.3.0-rc.4, the identical build passed. The RSC bundle includedstores-registration.jsas a one-byte module without treating it as an error.Passing gates
yarn install --frozen-lockfile --non-interactive(using an isolated Yarn cache)yarn build:dev(client, server, and RSC bundles all compiled successfully)bundle exec rake ci:js: 4 suites, 16 tests, 0 failures/: HTTP 200/server-components: HTTP 200 with the RSC demo, server environment, and live activity content/rsc_payload/ServerComponentsPage?props=%7B%7D: HTTP 200,application/x-ndjson, nonempty payloadspec/requests/server_components_spec.rb: 5 examples, 0 failuresspec/system/server_components_demo_spec.rb: 5 examples, 0 failuresbundle exec rake ci:rspec: 80 examples, 0 failuresreact/no-dangerwarning)The machine had a stale
chromedriver150 earlier inPATHwhile Chrome was 153. The first browser-only attempt failed before opening a session. Re-running with that stale executable excluded let Selenium Manager select the compatible driver, after which both targeted system specs and the full RSpec suite passed.Package provenance
The Yarn lockfile resolves
react-on-rails-rsc@19.3.0-rc.4from the public npm registry with integrity:The published package reports git head
78f78ce878dd7f84098d3128a453a2fb3bc7e258.Note
Medium Risk
Release-candidate upgrades across SSR, node renderer, and RSC bundling affect all client/server/RSC builds; risk is mitigated by lockfile-only changes and reported CI/smoke validation, but runtime behavior can still shift with RC bits.
Overview
Bumps the React on Rails stack to 17.1.0.rc.3 (Ruby
react_on_rails_pro/ npmreact-on-rails-proand node renderer) and pins React 19.2.8 withreact-on-rails-rsc@19.3.0-rc.4and matchingreact-server-dom-webpack, replacing the prior 17.0.0 / ~19.2.7 / 19.2.1-rc.1 set.Lockfiles (
Gemfile.lock,yarn.lock) and README version targets are refreshed so Ruby and JS stay aligned; Ruby transitive deps (e.g.async,async-http) move with the Pro gem.This is a downstream validation release for the RSC fix that allows empty
"use client"modules (e.g.stores-registration.js) to build without webpack errors—no application source changes in the diff.Reviewed by Cursor Bugbot for commit 318eb5d. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by CodeRabbit