fix: capitalize Code Push in how-to-install-flutter - #678
Merged
Merged
Conversation
Vale's Terms rule requires "Code Push". The occurrence spans a line break, which older Vale releases did not join, so it only started failing when the vale-action picked up a newer Vale: the same main commit (9796712) passed style-check on 2026-09-17 and failed on 2026-09-18. This is a main-branch failure inherited by this branch when main was merged in, not something this PR introduced.
This was referenced Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
style-checkis currently failing onmain. Vale'sTermsrule requires "Code Push", andhow-to-install-flutter.mdxhas one lowercase "code push" that spans a line break:Why it started failing now
Nothing in the repo changed.
vale-actioninstalls Vale atlatest, and v3.22.0 shipped between two runs of the same unchangedmaincommit9796712:Confirmed by pinning the binary rather than inferring it: Vale 3.22.0 flags that line at
342:76, matching CI exactly, while 3.15.1 and 3.17.1 report zero errors across all 74 files. Newer Vale joins the line break when matching, which makes the occurrence visible to the rule.Worth knowing for anyone debugging this locally: the repo pins
@vvago/vale: ^3.21.0, so anode_modulesinstalled before v3.22.0 will not reproduce it.vale --config=.vale.ini src/content/docscan report zero errors while CI fails. Checkvale --versionfirst.Impact
This blocks
style-checkon every open PR that is current withmain, including the Dependabot bump in #677, which has no other problems.Verification
Vale 3.22.0 against this branch: 0 errors across 74 files. Prettier and cspell clean. The same fix took #661 from a failing
style-checkto a fully green run (35325071831).