Skip to content

fix(oauth): drop ungrantable JSM Forms scopes from Jira scope list #4960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 2 commits into from
Jun 11, 2026
+8 −7
Merged

fix(oauth): drop ungrantable JSM Forms scopes from Jira scope list #4960

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4072ffa
fix(oauth): drop ungrantable JSM Forms scopes from Jira scope list
waleedlatif1 Jun 11, 2026
1458af6
fix(secrets): keep a fixed-length value mask for read-only viewers
waleedlatif1 Jun 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion ...spaceId]/settings/components/secrets/components/secret-value-field/secret-value-field.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,13 @@ import { ChipInput } from '@/components/emcn'

const BULLET = '\u2022'

/**
* Viewers always see this many bullets regardless of the real value, which the
* server withholds (empty string) for non-admins. A fixed length also avoids
* leaking the secret's length.
*/
const VIEWER_MASK_LENGTH = 10

type SecretValueFieldProps = Omit<
ComponentProps<'input'>,
'type' | 'value' | 'onChange' | 'readOnly'
Expand Down Expand Up @@ -50,7 +57,7 @@ export function SecretValueField({
const [focused, setFocused] = useState(false)
const editable = canEdit && !readOnly
const maskActive = canEdit && !unmasked && !focused
const displayValue = canEdit ? value : value ? BULLET.repeat(value.length) : ''
const displayValue = canEdit ? value : BULLET.repeat(VIEWER_MASK_LENGTH)
Comment thread
waleedlatif1 marked this conversation as resolved.

const mergedStyle: CSSProperties | undefined = maskActive
? ({ ...style, WebkitTextSecurity: 'disc' } as CSSProperties)
Expand Down
3 changes: 0 additions & 3 deletions apps/sim/lib/oauth/oauth.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -541,9 +541,6 @@ export const OAUTH_PROVIDERS: Record<string, OAuthProviderConfig> = {
'write:request.participant:jira-service-management',
'read:request.approval:jira-service-management',
'write:request.approval:jira-service-management',
'read:form:jira-service-management',
'write:form:jira-service-management',
'delete:form:jira-service-management',
],
},
},
Expand Down
3 changes: 0 additions & 3 deletions apps/sim/lib/oauth/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,9 +201,6 @@ export const SCOPE_DESCRIPTIONS: Record<string, string> = {
'Add and remove participants from customer requests',
'read:request.approval:jira-service-management': 'View approvals on customer requests',
'write:request.approval:jira-service-management': 'Approve or decline customer requests',
'read:form:jira-service-management': 'View JSM forms and templates',
'write:form:jira-service-management': 'Attach, save, and submit JSM forms',
'delete:form:jira-service-management': 'Delete JSM forms',

// Microsoft scopes
'User.Read': 'Read Microsoft user',
Expand Down
Loading