Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Interrupted HTTP/2 requests leave their streams open after the connection is released back to the pool. These abandoned streams consume the peer’s concurrent-stream capacity until the peer completes them, potentially causing healthy requests to fail with
GoawayError: Exceeded maximum concurrent streams.This change cancels an abandoned stream before the interruption propagates:
ensureand a completed flag aroundwrite_requestandread_response, covering both timeouts andAsync::Stop.RST_STREAMwithCANCELonly when the request is incomplete, the stream is active, and the connection is open.RefusedErrorchecks for GOAWAY and closed connections.A new loopback-server regression test times out
/slow, verifies that the stream registry is empty, and successfully requests/faston the same connection.