Add value equality for TLS configurations and trust stores - #34
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Equivalent TLS configurations currently compare by object identity, forcing connection caches to serialize and digest them to share clients by value. Add
==,eql?, andhashtoTLS::ConfigurationandTLS::TrustStoreso they can be used directly as cache keys.Equality includes the exact PEM strings, certificate order, trust store system-certificate policy, and configuration verification policy.
equal?retains its object-identity semantics. Freezing either object copies and freezes its nested certificate data, so a cache can retain an immutable snapshot without freezing the caller's configuration or its inputs:This supports removing Marshal serialization and SHA-256 cache keys from async-grpc-compatible #10. Existing redacted
inspectoutput keeps certificate and private-key material out of cache inspection.Validation on Ruby 4.0.7: