Use Ruby-style form data key - #6
Closed
samuel-williams-shopify wants to merge 1 commit into
Closed
samuel-williams-shopify wants to merge 1 commit into
samuel-williams-shopify wants to merge 1 commit into
Conversation
Signed-off-by: Samuel Williams <samuel.williams@shopify.com> Assisted-By: devx/7ef83274-928f-499d-b668-48449b1ff60e
Contributor
Author
|
Closing in favor of retaining the conventional JSON/JavaScript key name . |
Contributor
Author
|
Clarification: closing in favor of retaining the conventional JSON/JavaScript key name |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Send forwarded form entries using the
form_datawire key instead offormData. Protocol::WebSocket symbolizes JSON keys on the Ruby side, so this produces the conventionalevent[:form_data]interface.Form forwarding has not been released since its recent fix, making this the right point to establish the Ruby-facing name.
Testing
npm test