Remove inaccurate hints. - #94
Merged
Merged
Conversation
`iter_set_bits` and `iter_unset_bits` don't know -- unless one does `count_set_bits` - how many bits they will yield. That means that `size_hint` on these two iterators returned the size of the entire Vob which is always `>=` the number of set/unset bits. If used in idioms along the lines of `vob.iter_set_bits().collect()` this could cause significant overallocation. An open question is whether, in general, it's better to have `size_hint` call `count_[un]set_bits`. My guess is, in general, "no", but either way, for now the best thing to do is stop handing out misleading size hints.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
iter_set_bitsanditer_unset_bitsdon't know -- unless one doescount_set_bitshow many bits they will yield. That means thatsize_hinton these two iterators returned the size of the entire Vob which is always>=the number of set/unset bits. If used in idioms along the lines ofvob.iter_set_bits().collect()this could cause significant overallocation.An open question is whether, in general, it's better to have
size_hintcallcount_[un]set_bits. My guess is, in general, "no", but either way, for now the best thing to do is stop handing out misleading size hints.