Skip to content

fix(rune): replay queued displays once - #836

Open
11suixing11 wants to merge 1 commit into
source-academy:conductor-migrationfrom
11suixing11:fix/rune-display-replay
Open

fix(rune): replay queued displays once#836
11suixing11 wants to merge 1 commit into
source-academy:conductor-migrationfrom
11suixing11:fix/rune-display-replay

Conversation

@11suixing11

Copy link
Copy Markdown

Summary

  • queue rune display messages until the Rune tab sends its first request
  • replay the queued backlog exactly once when the tab requests it
  • keep later displays streaming live after the request has established the tab subscriber
  • add a regression test using the real Conductor Channel pair for the pre-request display flow

Reproduction covered

The new test fails on the previous implementation with render modes anaglyph, normal, anaglyph instead of the expected normal, anaglyph.

Tests

  • git diff --check
  • corepack yarn workspace @sourceacademy/bundle-rune test
  • corepack yarn workspace @sourceacademy/bundle-rune tsc
  • corepack yarn workspace @sourceacademy/bundle-rune lint
  • corepack yarn workspace @sourceacademy/bundle-rune build

Addresses #823.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@martin-henz
martin-henz requested a review from AaravMalani July 26, 2026 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant