Skip to content

fix: keep rune and repeat bundles conductor-safe - #837

Open
11suixing11 wants to merge 1 commit into
source-academy:conductor-migrationfrom
11suixing11:fix/conductor-safe-rune-repeat
Open

fix: keep rune and repeat bundles conductor-safe#837
11suixing11 wants to merge 1 commit into
source-academy:conductor-migrationfrom
11suixing11:fix/conductor-safe-rune-repeat

Conversation

@11suixing11

Copy link
Copy Markdown

Summary

  • replace rune/repeat Conductor bundle imports from modules-lib errors/utilities with Conductor errors/assertions or local pure helpers
  • keep repeat_internal synchronous without callWithoutMetadata so rune can import repeat without pulling js-slang externals
  • add local hexToColor/hueToRgb helpers used by rune color functions

Fixes #825

Testing

  • yarn workspace @sourceacademy/bundle-rune test
  • yarn workspace @sourceacademy/bundle-repeat test
  • yarn workspace @sourceacademy/bundle-rune tsc
  • yarn workspace @sourceacademy/bundle-repeat tsc
  • yarn workspace @sourceacademy/bundle-rune lint
  • yarn workspace @sourceacademy/bundle-repeat lint (passes with existing IModuleExport warning)
  • yarn workspace @sourceacademy/bundle-repeat build
  • yarn workspace @sourceacademy/bundle-rune build
  • rg "js-slang|@sourceacademy/modules-lib/(errors|utilities)|assertNumberWithinRange|callWithoutMetadata|InvalidParameterTypeError|GeneralRuntimeError" build/bundles/rune.js build/bundles/repeat.js -n (no matches)

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant