Skip to content

fix(sound): share pan sampling during playback - #838

Open
11suixing11 wants to merge 1 commit into
source-academy:conductor-migrationfrom
11suixing11:fix/sound-pan-shared-sampling
Open

fix(sound): share pan sampling during playback#838
11suixing11 wants to merge 1 commit into
source-academy:conductor-migrationfrom
11suixing11:fix/sound-pan-shared-sampling

Conversation

@11suixing11

Copy link
Copy Markdown

Summary

  • add regression tests showing play(pan(...)(sound)) samples the squashed source wave once per timestamp
  • add regression tests showing play(pan_mod(...)(sound)) samples both the source and mono modulator once per timestamp
  • let panned Sound values provide a shared stereo sampler for playback while preserving the existing left/right Wave accessors

Fixes #800

Testing

  • yarn workspace @sourceacademy/bundle-sound test
  • yarn workspace @sourceacademy/bundle-sound tsc
  • yarn workspace @sourceacademy/bundle-sound lint
  • yarn workspace @sourceacademy/bundle-sound compile
  • yarn workspace @sourceacademy/bundle-sound build
  • git diff --check

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@martin-henz

Copy link
Copy Markdown
Member

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jul 26, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai

coderabbitai Bot commented Jul 26, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@martin-henz, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 57 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 05a09d84-0429-4bf9-82b1-fea63f53a7e6

📥 Commits

Reviewing files that changed from the base of the PR and between 74a8de1 and f4cae7f.

📒 Files selected for processing (3)
  • src/bundles/sound/src/__tests__/sound.test.ts
  • src/bundles/sound/src/functions.ts
  • src/bundles/sound/src/types.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants