Add missing @sourceacademy/modules-testplugin devDependency to curve bundle - #853
Merged
Merged
Conversation
…bundle curve/src/__tests__/curve.test.ts imports TestDataHandler, callClosure, and runAsyncGenerator from @sourceacademy/modules-testplugin, but the bundle's package.json never declared it as a dependency (csg and plotly, migrated in the same PR, both declare it correctly). This was invisible in a full workspace install but breaks tsc in CI's isolated `yarn workspaces focus` install for the curve bundle job, producing "Cannot find module '@sourceacademy/modules-testplugin'" plus a cascade of implicit-any errors on the test file's callback parameters (their types depend on runAsyncGenerator's now-unresolvable signature).
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the `curve Bundle` CI failure from PR #680's run: https://github.com/source-academy/modules/actions/runs/30272720846
`src/bundles/curve/src/tests/curve.test.ts` imports `TestDataHandler`, `callClosure`, and `runAsyncGenerator` from `@sourceacademy/modules-testplugin`, but the bundle's `package.json` never declared it as a dependency. `csg` and `plotly` — migrated in the same PR (#840) — both declare it correctly, which is why only `curve` failed.
This was invisible in a full workspace install (hoisting made it resolvable anyway), but breaks `tsc` in CI's isolated `yarn workspaces focus` install for the curve bundle job:
plus a cascade of implicit-
anyerrors on the test file's callback parameters, since their types depend onrunAsyncGenerator's now-unresolvable signature.Verification
yarn workspaces focus @sourceacademy/bundle-curveinstall (matching what CI does)tscpasses cleanly, all 120 curve bundle tests pass (1 skipped)yarn constraintscleanyarn lint:all— no new errors/warnings🤖 Generated with Claude Code