Skip to content

Fix HTTP 404 response for unknown doc pages, and render during build #1860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marcleblanc2 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix HTTP 404 response for unknown doc pages, and render during build #1860

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0815502
fix: return a real HTTP 404 for unknown doc pages
marcleblanc2 Sep 6, 2026
9c29b39
chore: drop maxDuration from the doc page route
marcleblanc2 Sep 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions src/app/[...slug]/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,17 @@ import {getMDXComponent} from 'next-contentlayer/hooks';
import {notFound} from 'next/navigation';
import {Suspense} from 'react';

export const maxDuration = 300;
// Every page is enumerated by generateStaticParams. Reject unknown slugs at the
// router so the site returns a real HTTP 404. Without this, notFound() runs
// inside the root layout's <Suspense> after the response has started streaming,
// and the not-found page is served with status 200.
export const dynamicParams = false;

export const generateStaticParams = async () => {
return allPosts.map(post => ({
params: {slug: post._raw.flattenedPath.split('/')}
}));
return allPosts
// The root document is served by app/page.tsx, not this catch-all route.
.filter(post => post._raw.flattenedPath !== '')
.map(post => ({slug: post._raw.flattenedPath.split('/')}));
};

export const generateMetadata = ({params}: Props) => {
Expand Down