[stree] Fix propagation of memlets with undefined symbols - #2467
Open
mohsinm-dev wants to merge 3 commits into
Open
[stree] Fix propagation of memlets with undefined symbols#2467mohsinm-dev wants to merge 3 commits into
mohsinm-dev wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Normalize explicitly undefined symbols before memlet propagation and route subsets containing them through the conservative fallback. This prevents scope-local symbols from leaking into outer schedule-tree memlet summaries while preserving precise propagation for symbols that remain defined.
This also re-enables the symbol-assignment and dynamic-range schedule-tree regression tests, and adds coverage for affine expressions with string- and symbol-valued undefined-variable sets.
Closes #2293.
Testing
pre-commit run --all-files